Repository navigation
fix out-of-bounds write in blosc_getitem for negative nitems - #406
Merged
Merged
Conversation
blosc_getitem checked start and start+nitems against the buffer but never nitems itself, and did the checks with 32-bit multiplication. A negative nitems (with start > |nitems|) passed every bound, bsize2 = stopb - startb went negative, and fastcopy() received it as a size_t, writing far past dest. Reject nitems < 0 and do the range math in int64_t so the start*typesize checks cannot overflow either.
Member
|
LGTM. Thanks @suraiya-ctrl ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
blosc_getitem() rejects an out-of-range start and start+nitems, but never checks nitems on its own, and runs the checks in 32-bit:
Reject nitems < 0 and do the range math in int64_t. tests/test_getitem_bounds.c faults under AddressSanitizer on the current code and passes with the fix; the existing getitem round-trips are unchanged.