Test Bitcoin signing with shared vectors - #177
Closed
benma-agent wants to merge 1 commit into
Closed
Conversation
Consume the PSBT transaction vectors introduced by BitBoxSwiss/bitbox02-firmware#2017 in simulator signing tests. The PSBT conversion exercises the low-level signing protocol without duplicating each vector as a raw request. Centralize simulator stdout parsing and check versioned screens, errors, signature insertion, generated outputs, and final transactions. Close gaps exposed by the vectors: recognize Taproot policies when loading previous transactions, preserve existing Taproot script-path signatures, and forward silent-payment and payment-request metadata. Remove obsolete transaction test helpers superseded by the vectors and keep the simulator harness lint-clean.
benma-agent
force-pushed
the
benma-agent/add-simulator-v9.26.5
branch
from
August 23, 2026 18:39
ade2db3 to
e6d5f79
Compare
benma-agent
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consume the PSBT transaction vectors introduced by
BitBoxSwiss/bitbox02-firmware#2017 in
simulator signing tests. The PSBT conversion exercises the low-level
signing protocol without duplicating each vector as a raw request.
Centralize simulator stdout parsing and check versioned screens, errors,
signature insertion, generated outputs, and final transactions.
Close gaps exposed by the vectors: recognize Taproot policies when
loading previous transactions, preserve existing Taproot script-path
signatures, and forward silent-payment and payment-request metadata.
Remove obsolete transaction test helpers superseded by the vectors and
keep the simulator harness lint-clean.