Require antiklepto for signing - #176
Merged
benma merged 1 commit intoAug 24, 2026
Merged
Conversation
benma
marked this pull request as ready for review
August 23, 2026 12:38
Reject BTC transaction signing on firmware before 9.4.0 and BTC message or legacy ETH signing on firmware before 9.5.0. Remove silent legacy fallbacks so supported versions always perform the anti-klepto nonce-commitment protocol.
benma-agent
force-pushed
the
benma-agent/require-antiklepto
branch
from
August 23, 2026 12:39
54ef4a8 to
b355491
Compare
benma-agent
marked this pull request as draft
August 23, 2026 12:39
benma
marked this pull request as ready for review
August 23, 2026 18:25
bznein
approved these changes
Aug 24, 2026
bznein
left a comment
bznein
left a comment
Collaborator
There was a problem hiding this comment.
utACK with a minor comment
|
|
||
| // BTCSign signs a bitcoin or bitcoin-like transaction. The previous transactions of the inputs | ||
| // need to be provided if `BTCSignNeedsPrevTxs()` returns true. | ||
| // BTCSign signs a bitcoin or bitcoin-like transaction. Firmware v9.4.0 or newer is required to |
Collaborator
There was a problem hiding this comment.
Suggested change
| // BTCSign signs a bitcoin or bitcoin-like transaction. Firmware v9.4.0 or newer is required to | |
| // BTCSign signs a bitcoin or bitcoin-like transaction. Firmware v9.5.0 or newer is required to |
Contributor
There was a problem hiding this comment.
Why? It's actually v9.4.0 for btc tx signing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject BTC transaction signing on firmware before 9.4.0 and BTC message
or legacy ETH signing on firmware before 9.5.0.
Remove silent legacy fallbacks so supported versions always perform the
anti-klepto nonce-commitment protocol.