firmware: validate antiklepto signatures - #175
Merged
benma merged 1 commit intoAug 24, 2026
Merged
Conversation
cedwies
reviewed
Aug 11, 2026
cedwies
left a comment
cedwies
left a comment
Collaborator
There was a problem hiding this comment.
nice, just one question.
Use shared compact and recoverable ECDSA validators for direct signing responses and from inside Anti-Klepto verification. Reject invalid scalars, high-S encodings, and recovery IDs outside the secp256k1 range. Accept recovery IDs 0..3 for all recoverable ECDSA signatures. Add regression coverage for malformed signatures.
benma-agent
force-pushed
the
benma-agent/validate-antiklepto-signatures
branch
from
August 24, 2026 10:58
ab7b035 to
cdb6fcc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use shared compact and recoverable ECDSA validators for direct
signing responses and from inside Anti-Klepto verification. Reject
invalid scalars, high-S encodings, and recovery IDs outside the
secp256k1 range.
Accept recovery IDs 0..3 for all recoverable ECDSA signatures.
Add regression coverage for malformed signatures.
Same change as in BitBoxSwiss/bitbox-api-rs#129