Repository navigation
Conversation
Mesa 25.2.8-0ubuntu0.24.04.3 links libwayland-server from libEGL_mesa, adding it to the graphics boot delta. Keep the exact SONAME in the expected set so other unexpected libraries still fail the test. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused allowlist update matches the documented Mesa dependency without broadening other module exemptions.
Review effort: Balanced
Findings: None
What changed in this PR
Allows Mesa 25.2.8’s Wayland server dependency in the Linux module-load test.
Changes:
- Adds
libwayland-server.so.0to the expected Linux boot modules. - Preserves rejection of other unexpected modules.
| File | Description |
|---|---|
Apps/ModuleLoadTest/Source/App.X11.cpp |
Allows the new Mesa-loaded dependency. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Created by Copilot on behalf of @bghgary]
Context
Mesa 25.2.8-0ubuntu0.24.04.3 makes its EGL library load
libwayland-server.so.0. The Linux module-load test rejects that graphics dependency, blocking otherwise unrelated pull requests such as #1903 and #1905. This accepts that dependency while continuing to reject other unexpected modules.