Repository navigation
Restore the Babylon.js native Meshopt entry point - #1897
bkaradzic-microsoft merged 3 commits into
Conversation
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Restores Babylon.js’ expected native Meshopt compatibility entry point (_native.decodeMeshopt) by exporting it alongside the existing grouped codec API, and adds documentation + a regression test to ensure both entry points behave identically.
Changes:
- Export
_native.decodeMeshoptas a legacy alias to the existingDecodeMeshoptimplementation. - Update NativeMeshopt plugin README to document both
_native.decodeMeshoptand_native.MeshoptCodec.Decode. - Add a native unit test that validates byte-for-byte decode parity and invalid-mode rejection across both exports.
| File | Description |
|---|---|
| Plugins/NativeMeshopt/Source/NativeMeshopt.cpp | Adds the legacy _native.decodeMeshopt export wired to the existing decoder. |
| Plugins/NativeMeshopt/README.md | Documents the legacy free-function entry point alongside the grouped API. |
| Apps/UnitTests/Source/Tests.JavaScript.cpp | Adds a regression test asserting decode parity and invalid-mode rejection. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
Review effort: Lite
Findings: 1
Open (2)
Resolved since last review (1)
|
All 35 checks now pass on |
Review-Group: E4 Source: PR BabylonJS#1897 Squashed final review changes, including regressions and review follow-ups. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 60c2ec68-6de1-445d-9fc9-b699db737eae
Extract the decodeMeshopt compatibility export from shotgun without changing the grouped MeshoptCodec API or dependency pins. Cover decoding the existing reference stream and rejecting invalid modes through both entry points. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 723c9021-b79c-4089-9ff7-0d8ad63f1e98
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d35d0a8b-b073-4f2a-bbd3-a0b1d3584305
Label both tested entry points in failure messages while retaining the Uint8Array return contract. Use one named function type for both documented exports. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 723c9021-b79c-4089-9ff7-0d8ad63f1e98
425796d to
8ff76fe
Compare
Summary
Extracts only the
_native.decodeMeshoptcompatibility export from the BabylonNative shotgun branch onto official masterb8c93d24.Expose
_native.decodeMeshoptas a compatibility export using the existing decoder; retain_native.MeshoptCodec.Decodeand the codec version unchanged. Neither the pinned Babylon.js 9.21.2 package nor the current publicMeshoptCompressionimplementation consumes this native export; both use the script-based Meshopt decoder. This change does not add Babylon.js integration.Validation
Built the isolated branch with official dependency revisions, macOS/JavaScriptCore, RelWithDebInfo, and NativeMeshopt enabled. The regression requires no GPU:
UnitTests --gtest_filter="NativeMeshopt.*": 1 passed.No Babylon.js, bgfx, or JsRuntimeHost changes; no dependency bumps, visual references, tolerances, or exclusions.