Repository navigation
karpenter: build, package and deploy the unbounded-karpenter controller - #1120
Open
Israel Miller (imiller31) wants to merge 2 commits into
Open
Israel Miller (imiller31) wants to merge 2 commits into
Israel Miller (imiller31) wants to merge 2 commits into
Conversation
Add the unbounded-karpenter binary: upstream Karpenter's controllers compiled with the Unbounded cloud provider and the allocation lifecycle controller. make karpenter-manifests renders one manifest with the pinned upstream Karpenter CRDs, least-privilege RBAC, the Deployment and an admission policy that limits the plugin to allocations it owns and keeps it from changing their finalizers. make image-karpenter-local builds the image. Integration tests run the provider and the built binary against a real API server with the generated capacity CRDs.
The integration tests skip without KUBEBUILDER_ASSETS, and the Test job did not provide them, so CI built the binary but never ran the tests that exercise it. make karpenter-test-ci provisions the pinned assets first, the way racer-envtest-ci does.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on #1119.
Adds the
unbounded-karpenterbinary and what is needed to deploy it.What changed
cmd/unbounded-karpenter). Upstream Karpenter's controllers with the Unbounded cloud provider and the allocation lifecycle controller.internal/manifests,make karpenter-manifests). One rendered manifest with the upstream Karpenter CRDs taken from the pinned module, RBAC, and a two-replica leader-elected Deployment. The plugin may read MachineClasses and create, patch and delete MachineAllocations; it reads no Secrets or ConfigMaps.images/karpenter,make image-karpenter-local).internal/integration). Run the provider and the built binary against a real API server with the generated capacity CRDs and the rendered admission policy. They skip withoutKUBEBUILDER_ASSETS.Note
No provider on main serves MachineClass or MachineAllocation yet, so the plugin cannot autoscale a cluster until one lands. The AzureVM capacity adapter follows as a separate PR.
Testing
make karpenterandmake karpenter-manifests.