Repository navigation
fix(helm): match manager pods in default anti-affinity - #698
Merged
jmclong (jmclong) merged 1 commit intoNov 5, 2026
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the manager pod anti-affinity selector correction.
No open issues 🎉
What changed in this PR
Fixes #697 by aligning the Helm chart’s default manager pod anti-affinity selector with the actual pod labels, restoring the intended preference for placing manager replicas on different nodes.
Changes:
- Changes the selected component from
webhooktomanager. - Leaves pod labels, Deployment selectors, and the hostname topology key unchanged.
| File | Description |
|---|---|
charts/latest/values.yaml |
Corrects the default anti-affinity selector to match manager pods. |
Review effort: Balanced
Sergen Ciftci (sergenciftci)
marked this pull request as ready for review
November 5, 2026 18:10
Sergen Ciftci (sergenciftci)
requested review from
a team,
Simon Croome (croomes),
jmclong (jmclong) and
Lana Andreasyan (landreasyan)
as code owners
November 5, 2026 18:10
jmclong (jmclong)
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change the default manager anti-affinity selector from
component: webhooktocomponent: managerso it matches the actual pod labels and provides the intended hostname separation preference.Fixes #697.
Validation
helm lint charts/latestpassed.git diff --checkpassed.Prepared with AI assistance.