Repository navigation
Add modular Windows diagnostic manifests - #326
Open
Scott Roberts (Azure) (ScottAzure) wants to merge 4 commits into
Open
Scott Roberts (Azure) (ScottAzure) wants to merge 4 commits into
Scott Roberts (Azure) (ScottAzure) wants to merge 4 commits into
Conversation
Split the existing Windows diagnostic manifest into domain-focused modules, add Windows module selection docs, and add a targeted WGA mini-diagnostic gap-closure manifest. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add domain-focused Windows diagnostic fragments matching the existing diagnostic manifest operation set plus a targeted WGA mini-diagnostic gap-closure add-on. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep manifest files as the source of truth and rely on parse_manifest.py for generated documentation. Move rationale and module descriptions to the pull request body instead of adding a parallel docs source. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add parser-safe echo metadata to each Windows modular manifest so reviewers can see why each module exists, what it covers, and when to use it directly in the manifest diff. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
diagnosticmanifest into domain-focused modular manifests.docs/manifest_content.mdanddocs/manifest_by_file.mdare regenerated bytools/parse_manifest.py.diagnostic-wga-gap-closureas a targeted add-on formin-diagnosticinstead of broadening mini to the full diagnostic manifest.Design notes
The split is domain-based, not a literal copy of the current
diagnosticecho sections. Some existing sections are mixed or misleading: for example, onePlug and Playsection contains FSLogix collection, and theMSRDCollectsection includes RDInfra, identity, AppX/system, RDP, device-management, PowerShell, and probe entries.No hand-authored
docs/manifests/windows/*reference docs are included. The repository's established pattern is to update manifests and regenerate the two manifest index docs. Each modular manifest includes parser-safeechometadata for purpose, coverage, and when to use it, so the rationale is visible in file diffs without creating a parallel docs source.Manifest catalog: why each module exists and what it covers
diagnostic-registry-corediagnostic-events-corediagnostic-events-rdpdiagnostic-events-network-securitydiagnostic-events-directory-servicesdiagnostic-events-identitydiagnostic-events-system-servicesdiagnostic-events-storagediagnostic-events-azurediagnostic-provisioningdiagnostic-pnp-appinstalldiagnostic-domainjoindiagnostic-dotnetdiagnostic-guest-agent-corediagnostic-extensions-corediagnostic-extensions-azurediagnostic-extensions-aadlogindiagnostic-extensions-servicefabricdiagnostic-extensions-thirdpartydiagnostic-windows-updatediagnostic-proxyagentdiagnostic-avd-rdinfradiagnostic-msrdcollectdiagnostic-fslogixdiagnostic-arcdiagnostic-blobfusediagnostic-hpcdiagnostic-hpc-pack-2019diagnostic-hpc-pack-2016diagnostic-diskinfodiskinfo,output.diagnostic-miscdiagnostic-wga-gap-closuremin-diagnostica deliberate add-on when Windows Guest Analyzer coverage is the driver, without collecting fulldiagnostic.Cross-reference verification
diagnosticoperationsdiagnostic-wga-gap-closuretools/parse_manifest.pyand compared against a fresh parser runmin-diagnosticmin-diagnostic+diagnostic-wga-gap-closureWGA / driver-alignment notes
diagnostic-wga-gap-closureadds the artifact families needed by the Windows Guest Analyzer gaps found inmin-diagnostic, including RDP operational/session broker logs, WaSetup/Panther setup logs, extension CommandExecution logs, AADLoginForWindows command logs, scanresults.xml, msiexec.log, and the CrowdStrike C-00000291 driver marker.This keeps
min-diagnosticsmall while giving support workflows a deliberate add-on when Windows Guest Analyzer coverage is the driver.Validation
diagnostic-wga-gap-closure, are a lossless partition of the current Windowsdiagnosticmanifest: 348 unique ops, 0 missing, 0 extra.docs/manifest_content.mdanddocs/manifest_by_file.mdwithtools/parse_manifest.py.min-diagnosticimproves from 561 full / 9 partial / 10 none to 579 full / 1 none withdiagnostic-wga-gap-closure.