Update const-oid requirement from 0.9 to 0.10 - #370
Closed
dependabot[bot] wants to merge 1 commit into
Closed
Conversation
dependabot
Bot
added
dependencies
Member
|
@dependabot rebase |
Updates the requirements on [const-oid](https://github.com/RustCrypto/formats) to permit the latest version. - [Commits](RustCrypto/formats@const-oid/v0.9.0...const-oid/v0.10.0) --- updated-dependencies: - dependency-name: const-oid dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/cargo/const-oid-0.10
branch
from
April 3, 2025 12:57
c58ca06 to
b7f9a98
Compare
jhelovuo
added a commit
that referenced
this pull request
Aug 3, 2026
The only direct uses of const-oid were two `ObjectIdentifier::new_unwrap` calls in the S/MIME parser, compared against OIDs produced by the `der`/`cms` types (`econtent_type`, `attr.oid`). `der` already re-exports that exact type as `der::asn1::ObjectIdentifier` (via its `oid` feature), so we source the OID type from `der` instead and remove the direct const-oid dependency. This sidesteps dependabot #370 (const-oid 0.9 -> 0.10): const-oid 0.10 is the `der 0.8` generation and cannot coexist with der 0.7's re-exported 0.9 ObjectIdentifier (E0308 type mismatch). const-oid remains only as a transitive dep (0.9, via der/cms/x509-cert). MSRV unaffected. All 699 security tests pass. Co-authored-by: Cursor <cursoragent@cursor.com>
Member
|
@dependabot rebase |
Contributor
Author
|
Looks like const-oid is no longer a dependency, so this is no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the requirements on const-oid to permit the latest version.
Commits
2cf1d35const-oid v0.10.0 (#1672)ed08fc0Upgrade all crates to the 2024 edition; MSRV 1.85 (#1670)6efbe74base32ct v0.2.2 (#1671)967574csec1 v0.8.0-rc.4 (#1669)60007c0sec1: bumphex-literalfrom0.4.1to1.0.0(#1668)d4030f8sec1: upgrade to edition 2024; bump MSRV to 1.85 (#1666)6de6b2dfixup clippy 1.85 lints (#1664)63c3ba9tls_coded: remove measuring allocs in benchmarks (#1657)579ec92pkcs5: 0.8.0-rc.3 (#1660)ac0af8cpkcs8: 0.11.0-rc.2 (#1659)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)