Skip to content

fix(p2p): request the proposal for an explicit block and round - #1445

Draft
oXtxNt9U wants to merge 2 commits into
feat/p2p/get-messages-roundfrom
feat/p2p/get-proposal-round
Draft

fix(p2p): request the proposal for an explicit block and round#1445
oXtxNt9U wants to merge 2 commits into
feat/p2p/get-messages-roundfrom
feat/p2p/get-proposal-round

Conversation

@oXtxNt9U

@oXtxNt9U oXtxNt9U commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • GetProposal requests now carry a mandatory (blockNumber, round) query pinned from the job, so the responder serves exactly the requested round or nothing
  • removes the timing race where the responder answered from the requester's live headers (re-snapshotted at send time) and an honest reply for a moved round got the peer banned

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 12.05674% with 124 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.18%. Comparing base (b65766f) to head (8e735c3).

Files with missing lines Patch % Lines
...es/p2p/source/socket-server/codecs/proto/protos.js 11.51% 123 Missing ⚠️
packages/p2p/source/peer-communicator.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                       Coverage Diff                       @@
##           feat/p2p/get-messages-round    #1445      +/-   ##
===============================================================
- Coverage                        77.70%   77.18%   -0.52%     
===============================================================
  Files                              963      963              
  Lines                            17002    17141     +139     
  Branches                          2461     2462       +1     
===============================================================
+ Hits                             13211    13231      +20     
- Misses                            3784     3903     +119     
  Partials                             7        7              
Flag Coverage Δ
contracts 91.76% <ø> (ø)
packages 76.80% <12.05%> (-0.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@oXtxNt9U oXtxNt9U changed the title feat(p2p): request the proposal for an explicit block and round fix(p2p): request the proposal for an explicit block and round Aug 7, 2026
@oXtxNt9U
oXtxNt9U marked this pull request as ready for review August 10, 2026 04:33
@oXtxNt9U
oXtxNt9U force-pushed the feat/p2p/get-proposal-round branch from af53e69 to defaf24 Compare August 20, 2026 01:42
@oXtxNt9U
oXtxNt9U force-pushed the feat/p2p/get-proposal-round branch from defaf24 to 8e735c3 Compare August 25, 2026 05:42
@oXtxNt9U
oXtxNt9U marked this pull request as draft August 26, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant