fix(p2p): request the proposal for an explicit block and round - #1445
Draft
oXtxNt9U wants to merge 2 commits into
Draft
fix(p2p): request the proposal for an explicit block and round#1445oXtxNt9U wants to merge 2 commits into
oXtxNt9U wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/p2p/get-messages-round #1445 +/- ##
===============================================================
- Coverage 77.70% 77.18% -0.52%
===============================================================
Files 963 963
Lines 17002 17141 +139
Branches 2461 2462 +1
===============================================================
+ Hits 13211 13231 +20
- Misses 3784 3903 +119
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
oXtxNt9U
marked this pull request as ready for review
August 10, 2026 04:33
oXtxNt9U
force-pushed
the
feat/p2p/get-proposal-round
branch
from
August 20, 2026 01:42
af53e69 to
defaf24
Compare
oXtxNt9U
force-pushed
the
feat/p2p/get-proposal-round
branch
from
August 25, 2026 05:42
defaf24 to
8e735c3
Compare
oXtxNt9U
marked this pull request as draft
August 26, 2026 10:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetProposalrequests now carry a mandatory (blockNumber, round) query pinned from the job, so the responder serves exactly the requested round or nothingChecklist