Skip to content

AP_GPS: GSOF: support GPS_RAW_DATA for receiver internal logging - #35310

Open
ArnabOPP wants to merge 1 commit into
ArduPilot:masterfrom
ArnabOPP:gsof-raw-data-logging
Open

ArnabOPP wants to merge 1 commit into
ArduPilot:masterfrom
ArnabOPP:gsof-raw-data-logging

Conversation

@ArnabOPP

Copy link
Copy Markdown

Fixes #25517

Adds GPS_RAW_DATA handling to the GSOF (Trimble) backend so the receiver's internal logging can be started and stopped from the autopilot.

  • GPS_RAW_DATA=1: send the start-logging command once GSOF output configuration is done.
  • GPS_RAW_DATA=2: log until the first arm, stop on disarm, resume on re-arm (same semantics as the Septentrio backend).
  • Other non-zero values are rejected with a one-time GCS warning.
  • Start/stop packets are the ones given in the issue; the checksum is computed in code and matches the issue's bytes (0x62 / 0x63).
  • Updated the GPS_RAW_DATA parameter description.

Not done: parsing the receiver's ACK (the driver ignores ACKs for all requests today) and runtime parameter changes (stretch goal in the issue).

Testing

Not tested. This has not been compiled locally and has not been run against a PX-1 or in SITL; I am relying on CI for the build. A review from someone with a Trimble receiver would be very welcome.

🤖 Generated with Claude Code

Send the start/stop logging commands to Trimble receivers according to
GPS_RAW_DATA. Value 1 logs always; value 2 stops logging on disarm and
resumes on arm. Invalid values are rejected with a warning.

Fixes ArduPilot#25517

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 20, 2026 17:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AP_GPS_GSOF: Support GPS_RAW_DATA for external logging

2 participants