Repository navigation
Conversation
Send the start/stop logging commands to Trimble receivers according to GPS_RAW_DATA. Value 1 logs always; value 2 stops logging on disarm and resumes on arm. Invalid values are rejected with a warning. Fixes ArduPilot#25517 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25517
Adds GPS_RAW_DATA handling to the GSOF (Trimble) backend so the receiver's internal logging can be started and stopped from the autopilot.
GPS_RAW_DATA=1: send the start-logging command once GSOF output configuration is done.GPS_RAW_DATA=2: log until the first arm, stop on disarm, resume on re-arm (same semantics as the Septentrio backend).Not done: parsing the receiver's ACK (the driver ignores ACKs for all requests today) and runtime parameter changes (stretch goal in the issue).
Testing
Not tested. This has not been compiled locally and has not been run against a PX-1 or in SITL; I am relying on CI for the build. A review from someone with a Trimble receiver would be very welcome.
🤖 Generated with Claude Code