Repository navigation
Conversation
Previous review (2026-11-20)Automated review note — AI-generated (Claude+Codex), validated against the live diff. Please sanity-check before acting. Reviewed at head The rerun guards work as described: I re-ran the changed part of the installer three times at the merge-base and at this head, and the venv, completion and Docker source lines are now each written once instead of three times. The Minor (1)
The earlier note about the "Non-functional change" checkbox is dropped, since the template says to check all that apply. |
|
@khancyr please evaluate that minor point from the AI |
- check ~/.bashrc, where the completion line is written, instead of the login file - only append the venv activate line and the docker ~/.ardupilot_env source line if not already present - look for .git in ARDUPILOT_ROOT rather than the current directory, and accept a file so git worktrees get their submodules updated; skip it if git can't resolve it (e.g. a host worktree mounted in a container) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
not sure it would happens, but added as it cost pretty much nothing |
|
Automated review note — AI-generated (Claude+Codex), validated against the live diff. Please sanity-check before acting. Reviewed at head No new issues at this head: the rerun guards still write each rc line once, and a real repo or worktree still gets its submodules updated. The unreachable-gitdir case at install-prereqs-ubuntu.sh:640 is fixed: the installer now skips the submodule step and exits 0, where the previous head exited 128. Not fully reviewed: a full installer run on Ubuntu, Docker or Vagrant, and CI, which was still pending. |
Summary
found by claude, checked manually with a rerun.
Classification & Testing (check all that apply and add your own)
Description