Skip to content

fix(solid-email): silence html validation false positives #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Akin01 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(solid-email): silence html validation false positives #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion packages/solid-email/tsdown.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { defineConfig, type UserConfig } from 'tsdown';
import solid from 'vite-plugin-solid';
import solid, { type Options as SolidPluginOptions } from 'vite-plugin-solid';

const base: Pick<UserConfig, 'deps' | 'dts' | 'fixedExtension' | 'format'> = {
dts: true,
Expand All @@ -15,6 +15,18 @@ const base: Pick<UserConfig, 'deps' | 'dts' | 'fixedExtension' | 'format'> = {
fixedExtension: true,
};

type SolidCompilerOptions = NonNullable<SolidPluginOptions['solid']> & {
validate?: boolean;
};

const emailSolidCompilerOptions = {
// Solid's template validator assumes fragments will be parsed through
// innerHTML. Email components intentionally expose document-level
// <html>, <head>, and <body> roots, which browsers normalize when parsed
// as fragments even though Solid's SSR output is the desired final HTML.
validate: false,
} satisfies SolidCompilerOptions;

export default defineConfig([
{
...base,
Expand All @@ -26,6 +38,7 @@ export default defineConfig([
plugins: [
solid({
solid: {
...emailSolidCompilerOptions,
generate: 'ssr',
hydratable: false,
moduleName: 'solid-js/web/dist/server.js',
Expand All @@ -44,6 +57,7 @@ export default defineConfig([
plugins: [
solid({
solid: {
...emailSolidCompilerOptions,
generate: 'dom',
hydratable: false,
},
Expand Down
Loading