Hoist the eb_flow tracer device vector out of the MFIter loop. - #201
Open
WeiqunZhang wants to merge 1 commit into
Open
Hoist the eb_flow tracer device vector out of the MFIter loop.#201WeiqunZhang wants to merge 1 commit into
WeiqunZhang wants to merge 1 commit into
Conversation
It was constructed per box and destroyed right after the async ParallelFor that captures its data() pointer, so a kernel could read freed device memory. At function scope it outlives the loop, whose MFIter destructor synchronizes every stream used. The values are box-independent, so this also drops a per-box host-to-device copy. Fixes AMReX-Fluids#170.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was constructed per box and destroyed right after the async ParallelFor that captures its data() pointer, so a kernel could read freed device memory. At function scope it outlives the loop, whose MFIter destructor synchronizes every stream used. The values are box-independent, so this also drops a per-box host-to-device copy.
Fixes #170.