Add prob_lo to the Taylor-vortex cell coordinates in DiffFromExact. - #199
Open
WeiqunZhang wants to merge 1 commit into
Open
Add prob_lo to the Taylor-vortex cell coordinates in DiffFromExact.#199WeiqunZhang wants to merge 1 commit into
WeiqunZhang wants to merge 1 commit into
Conversation
The probtype 2 branch evaluated the exact solution at (i+0.5)*dx, an offset from the domain corner, while its init_taylor_vortex twin uses problo + (i+0.5)*dx, so error norms were wrong on shifted domains. Probtypes 1 and 16 are left alone: their inits omit problo too, so they already agree. Fixes AMReX-Fluids#167.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The probtype 2 branch evaluated the exact solution at (i+0.5)*dx, an offset from the domain corner, while its init_taylor_vortex twin uses problo + (i+0.5)*dx, so error norms were wrong on shifted domains. Probtypes 1 and 16 are left alone: their inits omit problo too, so they already agree.
Fixes #167.