Repository navigation
fix(api-rest): clear database routing context across request lifecycles - #968
Draft
srreejitbarat wants to merge 4 commits into
Draft
srreejitbarat wants to merge 4 commits into
srreejitbarat wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a controller throws or starts asynchronous handling, postHandle is skipped and the database ID can remain on a reused servlet thread. A later whitelist/admin request can inherit that route.
This clears stale context before route validation, performs synchronous cleanup in afterCompletion, and releases context at afterConcurrentHandlingStarted. Async redispatch establishes its own route; worker services continue selecting JDBC/transaction templates with explicit dbId. Invalid-route diagnostics no longer log request paths or database IDs.
Refs #958.
Validation — 16 October 2026:
The new upstream workflow requires maintainer approval: https://github.com/9tigerio/db2rest/actions/runs/38851879422 . The successful fork build does not replace that required check.
Draft pending maintainer review and upstream workflow approval. The timeout regression models a deferred timeout result and redispatch rather than a real container timer. The context-consumer inventory and reproduction notes are in design/database-context-lifecycle.md.
AI assistance was used for implementation, tests and documentation.