fix: harden runtime API and simulation handling - #718
Conversation
|
Note 🤖 Automated maintainer response — Generated by the MiroFish triage agent and checked against Reviewed against current main. The Zep 400-character query cap in this PR has now landed through #740 at the shared service boundary with regression tests for both graph search and profile enrichment. The provider configuration, IPC liveness, completed-state cleanup, initial-post handling, malformed JSON, BOM state, and psutil changes remain separate runtime work and have not been closed by #740. Please rebase and remove the now-duplicated Zep query change; this PR stays open for review of the remaining scope. |
2929097 to
690a6a2
Compare
|
Addressed in the force-updated head 690a6a2:
Validation after the rebase: backend 113 passed, frontend production build passed, and git diff --check passed. |
|
Note 🤖 Automated maintainer response — Generated by the MiroFish maintenance agent after reviewing this PR against Current The remaining provider request/header handling, IPC liveness, completed-state cleanup, initial-post behavior, malformed request handling, BOM state, and simulation UI changes are independent and remain eligible for review. Please rebase onto This PR stays open for the remaining runtime scope. |
690a6a2 to
d426d6b
Compare
|
Addressed in the force-updated head d426d6b:
Validation after the rebase: backend 133 passed, frontend production build passed, |
kemo04
left a comment
There was a problem hiding this comment.
AI Code Review (PR Review Agent)
- [Test Coverage · High] —
backend/app/api/simulation.py(diff line 92): New simulation prepared status 'paused' is added to prepared_statuses without corresponding test coverage.
|
Addressed the test-coverage review in 747c6a0:
Validation: the focused module passes 4 tests, the full backend suite passes 135 tests, and |
|
Scope reduced after the #758 cross-reference in bd4babb:
This is overlap coordination, not withdrawal of #718. Validation after the scope reduction: backend 135 passed, frontend production build passed, and |
|
@666ghj #718 is ready for maintainer review. I have addressed the prior maintainer and review feedback, added regression coverage for the persisted Current validation: backend 135 passed, frontend production build passed, and |
Summary
Fixes #717.
This PR hardens the remaining runtime paths exposed by an end-to-end run with an OpenAI-compatible provider, Zep Cloud, and dual-platform simulation.
Provider and API compatibility
Simulation lifecycle and IPC safety
psutilas a direct backend dependency because simulation liveness imports it directly.Action integrity and presentation
Scope coordination
forcehunk was removed from fix: harden runtime API and simulation handling #718. fix: harden runtime API and simulation handling #718 remains intended for merge for its independent runtime fixes; its remainingStep3Simulation.vuediff only concerns action filtering, counts, and display details.Validation
uv run python -m pytest -q: 135 passednpm run build: passedgit diff --check: passedThe frontend build emits the existing warnings about a large JavaScript chunk and a module that is both statically and dynamically imported. No new warning is introduced here.