Repository navigation
travel-team: check closed days against eastern time - #628
Merged
Merged
Conversation
The handler read the current day out of the host timezone. In production that's UTC, so between 7pm and midnight eastern it evaluated the wrong calendar day: silent on a holiday evening, chatty on a workday evening, and naming a holiday as the next workday. It also made the test suite fail for anyone developing east of UTC. Anchor both the weekday name and the holiday lookup to eastern time so they always agree on which day it is, and cover the evening window. Co-authored-by: OpenCode <ryan.ahearn@gsa.gov>
rahearn
enabled auto-merge
October 2, 2026 15:27
Sgtpluck
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The handler read the current day out of the host timezone. In production that's UTC, so between 7pm and midnight eastern it evaluated the wrong calendar day: silent on a holiday evening, chatty on a workday evening, and naming a holiday as the next workday. It also made the test suite fail for anyone developing east of UTC.
Anchor both the weekday name and the holiday lookup to eastern time so they always agree on which day it is, and cover the evening window.
Co-authored-by: OpenCode ryan.ahearn@gsa.gov
Checklist:
page has been updated if Charlie needs any new OAuth events or scopes
wiki page has been updated if new environment variables were introduced
or existing ones changed