Skip to content

Commit 2c409e4

Browse files
committed
docs(agents): check review threads and conversation comments every review cycle
Claude often posts its review as a PR conversation comment while other agents use review threads. Require both surfaces every cycle and define how to disposition a conversation-comment finding.
1 parent 2b10d99 commit 2c409e4

2 files changed

Lines changed: 3 additions & 0 deletions

File tree

‎.claude/skills/issue-pr-loop/SKILL.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,8 @@ Survey with `gh pr list --author @me --state open --json number,title,headRefNam
155155

156156
Inspect all review surfaces, including pagination and replies: REST `pulls/<N>/reviews`, `pulls/<N>/comments`, `issues/<N>/comments` under `repos/{owner}/{repo}`, and GraphQL `reviewThreads` with IDs, resolution state, bodies, authors, and timestamps.
157157

158+
Never infer a reviewer's surface from its identity: Claude often posts its review as a PR conversation comment (`issues/<N>/comments`), while other agents usually post review threads. Check both surfaces every cycle. Treat a conversation comment that carries findings or a verdict as a review; it has no thread to resolve, so disposition it with one PR comment that quotes or links it.
159+
158160
A `COMMENTED` review body can block with zero unresolved threads. Address outstanding concerns, `CHANGES_REQUESTED`, current inline findings, and unresolved threads. Empty acknowledgments are non-blocking. Assess older findings against the current head and later discussion; uncertain concerns block merging.
159161

160162
| State | Action |

‎AGENTS.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ All processors implement `IDisposable`/`IAsyncDisposable`; the README documents
6060

6161
## Pull request reviews
6262

63+
- Every review cycle, check both review threads (`pulls/<N>/reviews`, `pulls/<N>/comments`, GraphQL `reviewThreads`) and PR conversation comments (`issues/<N>/comments`). Reviewers differ: Claude often posts its review as a conversation comment, while other agents use review threads. A finding on either surface needs a disposition before merge.
6364
- Resolve each PR review thread, whether a human or a bot opened it, as soon as you have dispositioned it: the fix is pushed to the PR head and your reply names the commit, or your reply pushes back on the finding with evidence. Leave a thread open only while it has no disposition. If the reviewer replies after your disposition, unresolve the thread and handle the reply.
6465

6566
## Autonomous self-improvement

0 commit comments

Comments
 (0)