Skip to content

Commit 705a085

Browse files
wjablon1lgirdwood
authored andcommitted
ipc4: basefw: fix error code for invalid param IDs
Error code INVALID_PARAM is more generic and shall be used when a supported operation contains an invalid value in its data structure. For unsupported operations, INVALID_REQUEST shall be used instead. Signed-off-by: Wojciech Jablonski <wojciech.jablonski@intel.com>
1 parent 897ab03 commit 705a085

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

src/audio/base_fw_intel.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,7 @@ __cold int basefw_vendor_get_large_config(struct comp_dev *dev, uint32_t param_i
424424

425425
extended_param_id.full = param_id;
426426

427-
uint32_t ret = IPC4_ERROR_INVALID_PARAM;
427+
uint32_t ret = IPC4_INVALID_REQUEST;
428428

429429
switch (extended_param_id.part.parameter_type) {
430430
case IPC4_MEMORY_STATE_INFO_GET:
@@ -560,7 +560,7 @@ __cold int basefw_vendor_set_large_config(struct comp_dev *dev, uint32_t param_i
560560
break;
561561
}
562562

563-
return IPC4_UNKNOWN_MESSAGE_TYPE;
563+
return IPC4_INVALID_REQUEST;
564564
}
565565

566566
__cold int basefw_vendor_dma_control(uint32_t node_id, const char *config_data, size_t data_size)

0 commit comments

Comments
 (0)