Skip to content

This docker-compose file is completely broken #11

Description

@amalic
  • The .env which is being mounted does not exist.
  • Usage of $PWD doesn't make any sense since docker-compose can resolve relative paths.
  • An environment variable called $ROOT is being used and you expect a cert folder in it. In the nginx sub-folder you try to use letsencrypt. It would be smarter to not do https in your web-application but rather delegate it to something like jwilder/nginx-proxy with letsencrypt-companion
  • There is no need to map all exposed ports. I would recommend to only map port 80 of the web application. Within the docker-compose infrastructure all containers can access each other via network using the service-name from the docker-compose file.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions