sudoedit: don't overload EISDIR, it produces confusing error messages.

Author: millert

src/edit_open.c

@@ -386,7 +386,7 @@ sudo_edit_open_nonwritable(char *path, int oflags, mode_t mode,
 
     if (writable) {
 	close(dfd);
-	errno = EISDIR;
+	errno = EINVAL;
 	debug_return_int(-1);
     }
 

src/sesh.c

@@ -288,7 +288,7 @@ sesh_edit_create_tfiles(int edit_flags, struct sudo_cred *user_cred,
 		if (errno == ELOOP) {
 		    sudo_warnx(U_("%s: editing symbolic links is not "
 			"permitted"), path_src);
-		} else if (errno == EISDIR) {
+		} else if (errno == EINVAL) {
 		    sudo_warnx(U_("%s: editing files in a writable directory "
 			"is not permitted"), path_src);
 		} else {
@@ -388,7 +388,7 @@ sesh_edit_copy_tfiles(int edit_flags, struct sudo_cred *user_cred,
 	    if (errno == ELOOP) {
 		sudo_warnx(U_("%s: editing symbolic links is not "
 		    "permitted"), path_dst);
-	    } else if (errno == EISDIR) {
+	    } else if (errno == EINVAL) {
 		sudo_warnx(U_("%s: editing files in a writable directory "
 		    "is not permitted"), path_dst);
 	    } else {

src/sudo_edit.c

@@ -199,7 +199,7 @@ sudo_edit_create_tfiles(const struct command_details *command_details,
 	    if (ofd == -1 && errno == ELOOP) {
 		sudo_warnx(U_("%s: editing symbolic links is not permitted"),
 		    files[i]);
-	    } else if (ofd == -1 && errno == EISDIR) {
+	    } else if (ofd == -1 && errno == EINVAL) {
 		sudo_warnx(U_("%s: editing files in a writable directory is not permitted"),
 		    files[i]);
 	    } else {