Repository navigation
Drop countries and camps filed as organizations; add scripts/audit_entities.py - #65
Merged
Merged
Conversation
…facts, bad citations and duplicates Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FomNXbLBy4aAuCUi4jKM93
…dit_entities.py` Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FomNXbLBy4aAuCUi4jKM93
…nizations()`; test `scripts/audit_entities.py` Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FomNXbLBy4aAuCUi4jKM93
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc85019cd1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FomNXbLBy4aAuCUi4jKM93
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Alex · project thread
What this does
1. Countries and camps stop turning into organizations. In the 1 Nov 74-article Qwen run, 60 names showed up in two tables. Two patterns stood out:
countrylocation from that same article.drop_misfiled_organizations()now drops two kinds of organization:countrylocation from the same article. "France" goes; "French government" stays. "Israel" with no country location in that article stays.Dropped names are recorded in
phase_outcomes["misfiled_organizations"]with reasoncountryorfacility, next to the existingpersonreason.2.
scripts/audit_entities.pychecks a finished run without calling any model:--replayruns the same history checks onjust eval-replaysnapshots. It produced the numbers in the spot-check report.Not covered here
buildinglocations (universities, courts, the Senate, the White House) are left alone. Some of them are buildings too.Checks
ruff check,ruff format --check, the file-length check andpytest -m "not asyncio"all pass (566 passed). New tests are intests/test_misfiled_locations.pyandtests/test_audit_entities.py. CLAUDE.md is updated.Generated by Claude Code