Undo clears the all the content

[kesara]

This happens on macOS / Chromimum.
When a user presses Undo (CMD+Z) for the first time (or undo several times until a the last edit in the current session) on a page that already has content; Wiki JS clears all the content.
When this happens redo (CMD+Shift+Z) doesn't restore the content, only option is to close and cancel the edits of that session.

[mikhmol]

I traced this in the 2.x markdown editor: client/components/editor/editor-markdown.vue.

On init it loads the saved page and leaves that in the undo stack:

this.cm.setValue(this.$store.get('editor/content'))

setValue() is an undo step, and the state before it is empty. The first Cmd+Z, or undoing back to the start of the session, clears the page.

Redo fails on Chrome for Mac because inputStyle is contenteditable. Chrome deletes the text on its own undo stack, so Cmd+Shift+Z has nothing to restore. If that already happened, don't save. Close the editor and discard. The stored page is still there.

The same setValue() is in overwriteEditorContent in that file (the conflict overwrite). Add clearHistory() on the next line in both places, mounted() and that handler:

this.cm.setValue(this.$store.get('editor/content'))
this.cm.clearHistory()

clearHistory() has to come after setValue(). Then Cmd+Z only undoes what was typed in this session.

[NGPixel]

This is no longer an issue in v3.