Skip to content

docs: add missing @return tags to exported functions#827

Closed
LeonidasZhak wants to merge 1 commit into
r-lib:mainfrom
LeonidasZhak:docs/add-return-tags
Closed

docs: add missing @return tags to exported functions#827
LeonidasZhak wants to merge 1 commit into
r-lib:mainfrom
LeonidasZhak:docs/add-return-tags

Conversation

@LeonidasZhak

Copy link
Copy Markdown
Contributor

Summary

Adds @return roxygen tags and corresponding \value Rd sections to 6 exported function families in cli whose generated .Rd files lacked \value sections. R CMD check --as-cran notes missing \value for exported functions; this is also a CRAN submission requirement.

Changes

R source files (add @return roxygen tags)

File Functions @return
R/spark.R spark_bar(), spark_line() Character string of class cli_spark_bar/cli_spark_line
R/ruler.R ruler() NULL, invisibly
R/simple-theme.R simple_theme() Named list (theme)
R/format-conditions.R format_error(), format_warning(), format_message() Character string
R/test.R test_that_cli() Return value of testthat::test_that()

Rd files (manually added \value sections)

  • man/spark_bar.Rd, man/spark_line.Rd, man/ruler.Rd, man/simple_theme.Rd, man/format_error.Rd, man/test_that_cli.Rd

Bonus fix

  • R/bullets.R: Fix typo in roxygen comment — cli_format_bullets_raw()cli_bullets_raw() (the actual function name)

Validation

  • tools::checkRd() on all 6 modified Rd files: clean (spark_line.Rd has a pre-existing title-period warning, unrelated)
  • R CMD build --no-build-vignettes: succeeds
  • R CMD check --no-manual --no-vignettes: Status OK
  • Tests: pass

Duplicate check

  • Open PRs (18 total): none address missing @return tags or \value documentation
  • Open issues: searched "return", "value" — no matching issues

Add @return roxygen tags and corresponding \value Rd sections for:
- spark_bar(), spark_line() (R/spark.R)
- ruler() (R/ruler.R)
- simple_theme() (R/simple-theme.R)
- format_error(), format_warning(), format_message() (R/format-conditions.R)
- test_that_cli() (R/test.R)

Also fix typo in R/bullets.R: cli_format_bullets_raw() -> cli_bullets_raw()

R CMD check --as-cran requires \value for all exported functions.
@LeonidasZhak

Copy link
Copy Markdown
Contributor Author

Withdrawing this small automated PR while I consolidate an oversized batch of contributions and reduce maintainer review burden. Sorry for the noise, and thank you for maintaining the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant