Fix content submission error handling and JSON parsing issues - #116
Merged
Merged
Conversation
- Improve error handling in github-auth.js to handle non-JSON error responses - Add better logging for bot API errors with raw response text - Add final catch-all error handler in bot API to ensure valid JSON responses - Resolves 'A server e... is not valid JSON' error in content submission - Prevents HTML error pages from being returned as JSON responses Changes: 1. Enhanced error handling in createPullRequest method 2. Added try-catch for JSON parsing with fallback to text response 3. Added final error handler in bot API to prevent HTML responses 4. Improved error messages for better debugging
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
/approve |
Contributor
|
🚀 Admin-Approved and Auto-Merged! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Fix Content Submission Error Handling
Problem
Content submission was failing with "A server e... is not valid JSON" errors, indicating that the bot API was returning non-JSON responses (likely HTML error pages) when errors occurred.
Root Causes
Solution
Technical Changes
Files Changed
github-auth.js- Enhanced error handling in createPullRequest methodapi/github/create-content-pr.js- Added final catch-all error handlerImpact
Testing