Modules for virtual IPs

[danielpodwysocki]

Support for virtual IPs would be incredibly useful, helping to get one step closer to fully managing PFSense via Ansible.

[danielpodwysocki]

This is something that'd be awesome for environments I work with - would be happy to work on adding this in and try submitting a PR for it. Let me know if that'd be a useful contribution and I'll start looking into it.

[opoplawski]

I would be happy to add such a contribution. Thank you. Let me know if you have any questions. I need to move things to this repo, but for now https://github.com/opoplawski/ansible-pfsense/wiki/Developer-Notes might help get you started.

[genofire]

is part of #65

• i create a single PR see feat: add virtual-ip module #68 for faster merge

[rbullers]

I would also be very interested in this module - is there any update?

[irgama]

Also registering my interest. I will try to manually add the commit I see for this, but would like it in base.

[KhFrikha]

Hello, does anyone know why the default generation is for user module like that?

TODO - Add validation and parsing methods for parameters that require it

VIRTUAL_IP_ARG_ROUTE = dict(

TODO - These are just examples

authorizedkeys=dict(parse=p2o_ssh_pub_key),
password=dict(validate=validate_password),

)

VIRTUAL_IP_PHP_COMMAND_SET = r'''
require_once("filter.inc");
if (filter_configure() == 0) { clear_subsystem_dirty(''); }
'''

class PFSenseVirtualIpModule(PFSenseModuleConfigBase):
""" module managing pfsense virtual_ips """

##############################
# unit tests
#
# Must be class method for unit test usage
@staticmethod
def get_argument_spec():
    """ return argument spec """
    return VIRTUAL_IP_ARGUMENT_SPEC

def __init__(self, module, pfsense=None):
    super(PFSenseVirtualIpModule, self).__init__(module, pfsense, root='system', node='None', key='None', update_php=VIRTUAL_IP_PHP_COMMAND_SET,
                                            arg_route=VIRTUAL_IP_ARG_ROUTE)

def main():
module = AnsibleModule(
argument_spec=VIRTUAL_IP_ARGUMENT_SPEC,
required_if=VIRTUAL_IP_REQUIRED_IF,
supports_check_mode=True)

pfmodule = (module)
# Pass params for testing framework
pfmodule.run(module.params)
pfmodule.commit_changes()

if name == 'main':
main()

[opoplawski]

@KhFrikha I'm not sure what exactly you are asking. The generated module requires a decent amount of tweaking. It tries to give some examples of things you might need to do. I'll also note that you seem to have generated a config module, which isn't appropriate for virtual IPs.

[csuka]

any update?
can we get this into the main branch?