From 09fbcfe9e527b5f2e8e509a69f79a2f585383483 Mon Sep 17 00:00:00 2001
From: Pratik Jadhav <j.pratik025@gmail.com>
Date: Wed, 30 Sep 2026 21:34:31 +0530
Subject: [PATCH] Fix piped SQL output and document row limit

---
 README.md    | 5 +++++
 cmd/agent.go | 2 +-
 cmd/query.go | 9 +++++++--
 3 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/README.md b/README.md
index 5380501..426e12b 100644
--- a/README.md
+++ b/README.md
@@ -234,6 +234,11 @@ pb sql save "SELECT * FROM backend WHERE status = 500" --name=server-errors
 pb sql list
 ```
 
+SQL queries without an explicit `LIMIT` return at most 500 rows. Add a SQL
+`LIMIT` when you need more rows, including with `--output json`; JSON output
+does not fetch additional pages. Interactive mode (`-i`) fetches 500-row
+windows up to the SQL limit.
+
 OTel fields with dots like `service.name` and `http.status_code` work directly in queries without manual quoting.
 
 ## PromQL Workflows
diff --git a/cmd/agent.go b/cmd/agent.go
index 9b4805a..f67ea7d 100644
--- a/cmd/agent.go
+++ b/cmd/agent.go
@@ -109,7 +109,7 @@ func newAgentManifest() agentManifest {
 			{Command: "pb dataset info <dataset> -o json", Description: "Read dataset statistics and configuration", Scope: "server", Mutates: false, RequiresProfile: true},
 			{Command: "pb user list -o json", Description: "List users and their roles", Scope: "server", Mutates: false, RequiresProfile: true},
 			{Command: "pb role list -o json", Description: "List roles and privileges", Scope: "server", Mutates: false, RequiresProfile: true},
-			{Command: "pb sql run \"<SELECT query>\" --from <time> --to <time> -o json", Description: "Run a read-only SQL query", Scope: "server", Mutates: false, RequiresProfile: true, Constraints: []string{"Use SELECT-only SQL", "Never use --save-as because it creates a saved query"}},
+			{Command: "pb sql run \"<SELECT query>\" --from <time> --to <time> -o json", Description: "Run a read-only SQL query", Scope: "server", Mutates: false, RequiresProfile: true, Constraints: []string{"Use SELECT-only SQL", "Queries without a SQL LIMIT return at most 500 rows", "An explicit SQL LIMIT is not capped at 500 by pb; choose a reasonable limit to avoid large JSON responses", "Never use --save-as because it creates a saved query"}},
 			{Command: "pb sql list -o json", Description: "List saved SQL queries without opening the TUI", Scope: "server", Mutates: false, RequiresProfile: true},
 			{Command: "pb promql run \"<expression>\" --dataset <dataset> -o json", Description: "Run a PromQL query", Scope: "server", Mutates: false, RequiresProfile: true},
 			{Command: "pb promql labels <dataset> -o json", Description: "List PromQL label names", Scope: "server", Mutates: false, RequiresProfile: true},
diff --git a/cmd/query.go b/cmd/query.go
index 57d77e5..36bf1e8 100644
--- a/cmd/query.go
+++ b/cmd/query.go
@@ -34,6 +34,7 @@ import (
 	tea "github.com/charmbracelet/bubbletea"
 
 	"github.com/spf13/cobra"
+	"golang.org/x/term"
 )
 
 var (
@@ -54,7 +55,7 @@ var query = &cobra.Command{
 	Use:          "run [query] [flags]",
 	Example:      "  pb sql run \"select * from frontend\" --from=10m --to=now\n  pb sql run \"select * from frontend\" -i",
 	Short:        "Run SQL query on a dataset",
-	Long:         "\nRun SQL query on a dataset. Default output format is text.\nUse --output json for JSON output, or -i for interactive table view.",
+	Long:         "\nRun SQL query on a dataset. Default output format is text.\nUse --output json for JSON output, or -i for interactive table view.\nQueries without a SQL LIMIT return at most 500 rows.\nExplicit limits are not capped at 500 by pb; choose a reasonable value.",
 	Args:         cobra.MaximumNArgs(1),
 	SilenceUsage: true,
 	PreRunE:      PreRunDefaultProfile,
@@ -180,9 +181,13 @@ func parseTimeStr(s string) (time.Time, error) {
 	return time.Time{}, fmt.Errorf("unrecognized time format %q (use: now, 10m, 2h, 1d, or RFC3339)", s)
 }
 
-// startSpinner prints an animated spinner to stderr while a fetch is in progress.
+// startSpinner prints an animated spinner to stderr while a fetch is in progress and stderr is a terminal.
 // Call the returned function to stop it and clear the line.
 func startSpinner() func() {
+	if !term.IsTerminal(int(os.Stderr.Fd())) {
+		return func() {}
+	}
+
 	frames := []string{"|", "/", "-", "\\"}
 	done := make(chan struct{})
 	stopped := make(chan struct{})