Skip to content

remove nushell from CI to try to fix CI - #92

Merged
maxim-uvarov merged 1 commit into
mainfrom
feat/claude-code-fix2
Dec 13, 2025
Merged

maxim-uvarov merged 1 commit into
mainfrom
feat/claude-code-fix2

Conversation

@maxim-uvarov

Copy link
Copy Markdown
Member

No description provided.

@maxim-uvarov
maxim-uvarov merged commit 05be251 into main Dec 13, 2025
1 check failed
@maxim-uvarov

Copy link
Copy Markdown
Member Author

@claude can you check if why nushell causes the problem in ci?

@claude

claude Bot commented Dec 13, 2025 •

Copy link
Copy Markdown

Claude finished @maxim-uvarov's task in 2m 24s —— View job


Investigation Complete: nushell CI Issue Analysis

  • Read the current workflow files to understand the structure
  • Examine what was removed from the workflows
  • Check current CI status
  • Analyze the CI failure
  • Provide findings and explanation

Key Finding: Nushell was NOT the problem!

I've analyzed the failed CI run (job 57983934851) and the workflow files. Here's what actually happened:

The Real Issue: Workflow Validation Error

The CI failure was not caused by nushell. The actual error was:

401 Unauthorized - Workflow validation failed. The workflow file must exist 
and have identical content to the version on the repository's default branch.

This error occurs when:

  1. Workflow files are added or modified in a PR
  2. GitHub's security validation prevents the workflow from running with elevated permissions until it's merged to the default branch
  3. This is by design to prevent malicious workflow changes in PRs

The error message even says: "If you're seeing this on a PR when you first add a code review workflow file to your repository, this is normal and you should ignore this error."

Current State

Looking at the current workflows (.github/workflows/claude-code-review.yml and .github/workflows/claude.yml):

  • Neither file contains any nushell installation steps
  • The workflows reference nushell commands in claude_args: Bash(nu toolkit.nu testing:*) and Bash(use numd;*)
  • This suggests the workflows expect nushell to be pre-installed on the runner OR were relying on removed installation steps

What PR #92 Likely Did

Based on the PR title "remove nushell from CI to try to fix CI" and the deletion count (10 lines):

  • Hypothesis: The PR removed nushell installation steps (likely 5 lines from each workflow file)
  • Why this "fixed" the CI: It didn't actually fix anything - the validation error persists because the workflows are still not on the default branch with identical content
  • The current failure (seen in the logs) is still the same workflow validation error, NOT a nushell-related error

Recommendation

The CI workflows are currently failing due to workflow validation, not nushell. To properly fix this:

  1. Merge the workflows to main first - This resolves the validation error
  2. Then decide if nushell is needed:
    • If the workflows need to run nu commands (nu toolkit.nu testing, etc.), you'll need to add nushell installation steps back
    • If not needed, remove the nushell command references from claude_args

The current state (no nushell installation + nushell commands in allowed tools) will likely cause issues once the validation error is resolved and Claude tries to run nu commands.


@maxim-uvarov
maxim-uvarov deleted the feat/claude-code-fix2 branch December 14, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant