Skip to content

Commit 9ca4f2f

Browse files
committed
Remove check_suite_focus=true
This is no longer used by GitHub.¹ ¹ https://cmbuckley.co.uk/blog/2024/04/09/deep-links-to-github-actions-job-logs/
1 parent 5b4c394 commit 9ca4f2f

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

‎scripts/notify-on-job-fail‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ message="❌ ${job_name} job has FAILED 😞 "
1717
if [[ -n "${AWS_BATCH_JOB_ID}" ]]; then
1818
message+="See AWS Batch job \`${AWS_BATCH_JOB_ID}\` (<https://console.aws.amazon.com/batch/v2/home?region=us-east-1#jobs/detail/${AWS_BATCH_JOB_ID}|link>) for error details. "
1919
elif [[ -n "${GITHUB_RUN_ID}" ]]; then
20-
message+="See GitHub Action <https://github.com/${github_repo}/actions/runs/${GITHUB_RUN_ID}?check_suite_focus=true|${GITHUB_RUN_ID}> for error details. "
20+
message+="See GitHub Action <https://github.com/${github_repo}/actions/runs/${GITHUB_RUN_ID}|${GITHUB_RUN_ID}> for error details. "
2121
fi
2222

2323
"$bin"/notify-slack "$message"

‎scripts/notify-on-job-start‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ echo "Notifying Slack about started ${job_name} job."
1616
message="${job_name} job has started."
1717

1818
if [[ -n "${GITHUB_RUN_ID}" ]]; then
19-
message+=" The job was submitted by GitHub Action <https://github.com/${github_repo}/actions/runs/${GITHUB_RUN_ID}?check_suite_focus=true|${GITHUB_RUN_ID}>."
19+
message+=" The job was submitted by GitHub Action <https://github.com/${github_repo}/actions/runs/${GITHUB_RUN_ID}|${GITHUB_RUN_ID}>."
2020
fi
2121

2222
if [[ -n "${AWS_BATCH_JOB_ID}" ]]; then

0 commit comments

Comments
 (0)