Fall back to browser for inaccessible GitHub links (#8958)

* Fall back for inaccessible GitHub links

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Attestation commit

* Prepare 0.166.1 release

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Alex Dima <alexdima@microsoft.com>

Author: 3 people

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 0.166.1
+
+### Fixes
+
+- Fall back to the browser when a GitHub link cannot be resolved. https://github.com/microsoft/vscode-pull-request-github/issues/8959
+
 ## 0.166.0
 
 ### Changes

package-lock.json

@@ -44,7 +44,7 @@
 		"treeItemMarkdownLabel",
 		"treeViewMarkdownMessage"
 	],
-	"version": "0.166.0",
+	"version": "0.166.1",
 	"publisher": "GitHub",
 	"engines": {
 		"node": ">=20",

package.json

@@ -49,7 +49,7 @@ class GitHubIssueOrPullRequestExternalUriOpener extends Disposable implements vs
 				return;
 			}
 			if (!pullRequest) {
-				await vscode.window.showErrorMessage(vscode.l10n.t('Unable to find pull request #{0} in {1}/{2}.', identity.number, identity.owner, identity.repo));
+				await openWithDefaultExternalOpener(openContext.sourceUri);
 				return;
 			}
 			await PullRequestOverviewPanel.createOrShow(
@@ -65,7 +65,7 @@ class GitHubIssueOrPullRequestExternalUriOpener extends Disposable implements vs
 				return;
 			}
 			if (!issue) {
-				await vscode.window.showErrorMessage(vscode.l10n.t('Unable to find issue #{0} in {1}/{2}.', identity.number, identity.owner, identity.repo));
+				await openWithDefaultExternalOpener(openContext.sourceUri);
 				return;
 			}
 			await IssueOverviewPanel.createOrShow(

src/github/externalUriOpener.ts

@@ -27,7 +27,7 @@ describe('GitHubIssueOrPullRequestExternalUriOpener', () => {
 		sandbox.restore();
 	});
 
-	it('creates a remote-only folder manager when no local manager is available', async () => {
+	it('opens an unresolved issue with the default external opener', async () => {
 		const context = new MockExtensionContext();
 		const telemetry = new MockTelemetry();
 		const credentialStore = new CredentialStore(telemetry, context);
@@ -46,7 +46,7 @@ describe('GitHubIssueOrPullRequestExternalUriOpener', () => {
 			assert.ok(this.repository instanceof RemoteOnlyRepository);
 			return undefined;
 		});
-		sandbox.stub(vscode.window, 'showErrorMessage').resolves(undefined);
+		const openExternal = sandbox.stub(vscode.env, 'openExternal').resolves(true);
 
 		try {
 			await configuration.update(OPEN_PULL_LINKS, true, vscode.ConfigurationTarget.Global);
@@ -62,6 +62,51 @@ describe('GitHubIssueOrPullRequestExternalUriOpener', () => {
 
 			assert.strictEqual(repositoriesManager.folderManagers.length, 0);
 			assert.strictEqual(resolveIssue.callCount, 1);
+			assert.ok(openExternal.calledOnceWith(uri, { allowContributedOpeners: 'default' }));
+		} finally {
+			cancellation?.dispose();
+			registration?.dispose();
+			folderRepositoryManagerResolver.dispose();
+			repositoriesManager.dispose();
+			credentialStore.dispose();
+			context.dispose();
+		}
+	});
+
+	it('opens an unresolved pull request with the default external opener', async () => {
+		const context = new MockExtensionContext();
+		const telemetry = new MockTelemetry();
+		const credentialStore = new CredentialStore(telemetry, context);
+		const repositoriesManager = new RepositoriesManager(credentialStore, telemetry);
+		const folderRepositoryManagerResolver = new FolderRepositoryManagerResolver(context, repositoriesManager, telemetry);
+		let opener: vscode.ExternalUriOpener | undefined;
+		let registration: vscode.Disposable | undefined;
+		let cancellation: vscode.CancellationTokenSource | undefined;
+		sandbox.stub(vscode.window, 'registerExternalUriOpener').callsFake((_id, value) => {
+			opener = value;
+			return new vscode.Disposable(() => undefined);
+		});
+		const resolvePullRequest = sandbox.stub(FolderRepositoryManager.prototype, 'resolvePullRequest').callsFake(async function (this: FolderRepositoryManager) {
+			assert.ok(this.repository instanceof RemoteOnlyRepository);
+			return undefined;
+		});
+		const openExternal = sandbox.stub(vscode.env, 'openExternal').resolves(true);
+
+		try {
+			registration = registerGitHubIssueOrPullRequestExternalUriOpener(
+				context,
+				folderRepositoryManagerResolver,
+				telemetry,
+			);
+			const uri = vscode.Uri.parse('https://github.com/microsoft/vscode/pull/1');
+			assert.ok(opener);
+			sandbox.stub(opener as any, 'isOpenPullLinksEnabled').returns(true);
+			cancellation = new vscode.CancellationTokenSource();
+			await opener.openExternalUri(uri, { sourceUri: uri }, cancellation.token);
+
+			assert.strictEqual(repositoriesManager.folderManagers.length, 0);
+			assert.strictEqual(resolvePullRequest.callCount, 1);
+			assert.ok(openExternal.calledOnceWith(uri, { allowContributedOpeners: 'default' }));
 		} finally {
 			cancellation?.dispose();
 			registration?.dispose();