Skip to content

Commit 032ae4c

Browse files
committed
test: align null payload cases with success contract
1 parent 015e89c commit 032ae4c

2 files changed

Lines changed: 6 additions & 15 deletions

File tree

‎ManagedCode.Communication.Tests/Extensions/ResultConversionExtensionsTests.cs‎

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -40,18 +40,11 @@ public void AsResult_WithIntValue_CreatesSuccessfulResult()
4040
}
4141

4242
[Test]
43-
public void AsResult_WithNullValue_CreatesSuccessfulResultWithNull()
43+
public void AsResult_WithNullValue_RejectsInvalidSuccess()
4444
{
45-
// Arrange
4645
string? value = null;
4746

48-
// Act
49-
var result = value.AsResult();
50-
51-
// Assert
52-
result.IsSuccess.ShouldBeTrue();
53-
result.Value.ShouldBeNull();
54-
result.Problem.ShouldBeNull();
47+
Should.Throw<ArgumentNullException>(() => value.AsResult());
5548
}
5649

5750
[Test]

‎ManagedCode.Communication.Tests/Orleans/Serialization/ResultSerializationTests.cs‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -117,18 +117,16 @@ public async Task ResultT_WithComplexValue_ShouldSerializeCorrectly()
117117
}
118118

119119
[Test]
120-
public async Task ResultT_WithNullValue_ShouldSerializeCorrectly()
120+
public async Task ResultT_WithNullFailureValue_ShouldSerializeCorrectly()
121121
{
122-
// Arrange
123122
var grain = _grainFactory.GetGrain<ITestSerializationGrain>(Guid.NewGuid());
124-
var result = Result<string?>.Succeed((string?)null);
123+
var result = Result<string?>.Fail();
125124

126-
// Act
127125
var echoed = await grain.EchoResultAsync(result);
128126

129-
// Assert
130-
echoed.IsSuccess.ShouldBeTrue();
127+
echoed.IsFailed.ShouldBeTrue();
131128
echoed.Value.ShouldBeNull();
129+
echoed.Problem.ShouldNotBeNull();
132130
}
133131

134132
[Test]

0 commit comments

Comments
 (0)