-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[Issue] Fix the product gallery tab when an image attribute label contains a single quote #40519
Copy link
Copy link
Labels
Area: ContentComponent: MediaGalleryIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P2A defect with this priority could have functionality issues which are not to expectations.A defect with this priority could have functionality issues which are not to expectations.Reported on 2.4.xIndicates original Magento version for the Issue report.Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchThe issue has been reproduced on latest 2.4-develop branch
Metadata
Metadata
Assignees
Labels
Area: ContentComponent: MediaGalleryIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P2A defect with this priority could have functionality issues which are not to expectations.A defect with this priority could have functionality issues which are not to expectations.Reported on 2.4.xIndicates original Magento version for the Issue report.Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchThe issue has been reproduced on latest 2.4-develop branch
Type
Fields
Give feedbackNo fields configured for issues without a type.
Projects
StatusShow more project fields
Ready for Development
This issue is automatically created based on existing pull request: #40517: Fix the product gallery tab when an image attribute label contains a single quote
Description (*)
The
data-typesattribute in the admin product gallery is delimited using single quotes with@noEscape. When an image attribute label contains a single quote (e.g.Image d'exemple), the attribute is cut off and the gallery breaks.Fix: use
escapeHtmlAttr()with double quotes, consistent withdata-imageson the line above.Introduced in 17f0f4d (MAGETWO-99285), where
escapeHtml()was replaced with@noEscapeinstead ofescapeHtmlAttr().Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Image d'exemple)Contribution checklist (*)