Skip to content

react-contenteditable fails with pnpm strict mode — missing peerDependency on @types/react #287

Description

@baraknaveh

react-contenteditable@3.3.7 ships .d.ts files that import from react:

import * as React from 'react';

TypeScript resolves these types through @types/react, but the package only declares react as a peer dependency — not @types/react. This works in flat node_modules layouts (npm, yarn) because @types/react is hoisted from the consuming project. When pnpm hoisting is disabled (hoist: false), TypeScript cannot find the React types and fails with:

error TS2307: Cannot find module 'react' or its corresponding type declarations.

Workaround:

packageExtensions:
  "react-contenteditable@3":
    peerDependencies:
      "@types/react": "*"

Suggested fix: Add @types/react to peerDependencies in react-contenteditable's package.json.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions