Skip to content

Commit 9630cbb

Browse files
committed
ci: drop the early-exit branch from the Apollo wait loop
The healthcheck in the compose file keeps the config service from dying in the first place, so the loop no longer needs to detect a container that has given up.
1 parent 492af80 commit 9630cbb

1 file changed

Lines changed: 0 additions & 7 deletions

File tree

‎.github/workflows/ci-main.yml‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -247,13 +247,6 @@ jobs:
247247
echo "Apollo is serving configuration."
248248
exit 0
249249
fi
250-
# The container gives up on its own after 120 seconds. Once it has,
251-
# nothing will ever answer, so stop burning the remaining budget.
252-
if docker compose -f ".github/workflows/apollo/docker-compose.yml" logs apollo-quick-start 2>/dev/null | grep -Fq 'Config service failed to start'; then
253-
echo "Apollo config service gave up during startup."
254-
docker compose -f ".github/workflows/apollo/docker-compose.yml" logs --tail=50
255-
exit 1
256-
fi
257250
sleep 5
258251
done
259252
echo "Apollo did not start serving configuration within 5 minutes."

0 commit comments

Comments
 (0)