Skip to content

Don't allow NaN as a selection value #852

Description

@dlindhol

Selections use Scalar.convertValue given the string value from a selection expression. Unlike other non-numeric strings that will result in a error, "NaN".toDouble does produce a Double.NaN. This is fine in general but not for selections which need to have a well defined ordering. We could arguably handle "foo=NaN", but we can worry about that later, not forgetting that NaN != NaN.

In lieu of standard Operation validation, we could do something in the predicate method. We wouldn't want to simply look for the string "NaN" since it could be a valid value for a text variable.

Related to #305

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions