Repository navigation
Conversation
|
All contributors have signed the CLA. ✅ 所有贡献者均已签署 CLA。 |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
dadachann
added a commit
to langbot-app/cla
that referenced
this pull request
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provider messages define
ContentElement.file_base64, but bothMessageandMessageChunkomit it when building a platform message chain. A Runner can return a valid inline file throughmessage.deltaormessage.completedand the file is silently discarded before an adapter receives it.Add the missing conversion to
File(base64=..., name=...)in both paths. Preserve content order and the original payload, retain empty files, skip missing payloads consistently with adjacent media branches, and use the platform model's empty-name default when the optional filename is absent.Refs langbot-app/LangBot#2733. LangBot's pinned SDK must adopt a release containing this fix before running installations receive the behavior.
Regression coverage
23 parameterized cases cover full and streaming messages, binary and empty files, Unicode/optional names, mixed content order, first-text prefixes, file-only prefixes, Host attachments, input immutability, and JSON round-trips through
message.delta,message.completed, andrun.completed.The unchanged baseline produced 21 failures and 2 passes in these tests. After the fix, all 23 cases and the related 98-test entity/Runner set passed.
Validation
The macOS full run had 2,002 passes and one pre-existing failure: a runtime FD test reads Linux-only
/proc/self/fd. The same failure reproduced in an unmodified01533c4worktree; the complete Linux run passed it. Environment-dependent skips remain visible in the validation record.See the usage and regression guide. Actual WeCom delivery was not exercised; this change verifies SDK conversion and Runner serialization without changing platform APIs, wire fields, dependencies, or release versions.