Repository navigation
feat: k8s nodepool taints - #708
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Taint validation occurs after API reads, while cleanup polling can mistake transient failures for completed deletion.
2 open findings
What changed in this PR
Adds Kubernetes node-pool taint management to the compute CLI.
Changes:
- Adds create/update taint parsing, completion, and output formatting.
- Documents and tests replacement, preservation, and removal behavior.
- Expands integration cleanup polling.
| File | Description |
|---|---|
CHANGELOG.md |
Records taint support. |
internal/constants/constants.go |
Defines the taints flag. |
commands/compute/k8s/nodepool/create.go |
Adds create flag and help. |
commands/compute/k8s/nodepool/update.go |
Adds update flag and help. |
commands/compute/k8s/nodepool/run_k8s_nodepool.go |
Parses and applies taints. |
commands/compute/k8s/nodepool/nodepool.go |
Adds the Taints output column. |
commands/compute/k8s/nodepool/taints_test.go |
Tests parsing and payload behavior. |
test/suites/compute/k8s.bats |
Adds end-to-end taint coverage. |
docs/subcommands/Managed-Kubernetes/nodepool/create.md |
Documents create behavior. |
docs/subcommands/Managed-Kubernetes/nodepool/update.md |
Documents update behavior. |
docs/subcommands/Managed-Kubernetes/nodepool/get.md |
Lists the new column. |
docs/subcommands/Managed-Kubernetes/nodepool/list.md |
Lists the new column. |
docs/subcommands/Managed-Kubernetes/nodepool/delete.md |
Lists the new column. |
docs/subcommands/Managed-Kubernetes/nodepool/lan/remove.md |
Lists the new column. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
cavramoniu-ionos
approved these changes
Oct 22, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.