Repository navigation
fix: various workflows issues - #703
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the (fully commented-out) Trivy GitHub Actions workflow that was previously kept in the repository but no longer active, to avoid CI/badge failures associated with an invalid workflow file.
Changes:
- Deleted
.github/workflows/trivy.yml(previously entirely commented out) to prevent GitHub Actions from treating it as a failing workflow.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
30fdd81 to
7e6616a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 152 changed files in this pull request and generated no new comments.
Suppressed comments (1)
.github/workflows/ci.yml:61
- This change switches PR CI from
make test(which runs the bats-core suites viatest/run.sh) tomake itest, meaning bats-based E2E/regression coverage is no longer run automatically on pull requests. This is a significant CI behavior change (not just a formatting fix) and can make PRs look green while bats suites are failing or being skipped.
If the intent is to gate bats suites separately, consider explicitly documenting that in the PR description and ensuring the /test <suite> workflow is required (or at least prominently surfaced) for PRs that touch affected areas.
- name: Run unit and integration tests on Ubuntu
# BATS suites are intentionally excluded here; devs trigger them per-PR
# via a `/test <suite>` comment (see e2e.yml + pr-comment-trigger.yml).
env:
|

This PR:
cryptopkgTrivy workflow had been disabled, but since it is a fully commented .yml it fails and the README CI badge appears red because of it.
We still have govulncheck running regularly and on CIs