Skip to content

fix: various workflows issues - #703

Merged
avirtopeanu-ionos merged 6 commits into
masterfrom
rm/trivy
Aug 18, 2026
Merged

avirtopeanu-ionos merged 6 commits into
masterfrom
rm/trivy

Conversation

@avirtopeanu-ionos

@avirtopeanu-ionos avirtopeanu-ionos commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor

This PR:

  • removes fully commented-out trivy workflow. (fix failing CI badge on README)
  • Fixes a CI formatting bug
  • Fixes govulncheck CI step by bumping crypto pkg
  • Fixes a few edge cases where e2e.yml would fail to show its status or potentially get stuck in "RUNNING" status
  • Pins govulncheck to v1.7.0 instead of latest

Trivy workflow had been disabled, but since it is a fully commented .yml it fails and the README CI badge appears red because of it.

We still have govulncheck running regularly and on CIs

@avirtopeanu-ionos
avirtopeanu-ionos requested review from a team, adeatcu-ionos, cavramoniu-ionos, cristiGuranIonos, mimihalescu and rmocanu-ionos and a lite review from Copilot and removed request for a team August 18, 2026 08:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the (fully commented-out) Trivy GitHub Actions workflow that was previously kept in the repository but no longer active, to avoid CI/badge failures associated with an invalid workflow file.

Changes:

  • Deleted .github/workflows/trivy.yml (previously entirely commented out) to prevent GitHub Actions from treating it as a failing workflow.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@avirtopeanu-ionos avirtopeanu-ionos changed the title rm: trivy workflow fix: rm trivy workflow (fix red readme badge), ci.yml formatting fix Aug 18, 2026
@avirtopeanu-ionos
avirtopeanu-ionos requested a lite review from Copilot August 18, 2026 10:05
@avirtopeanu-ionos avirtopeanu-ionos changed the title fix: rm trivy workflow (fix red readme badge), ci.yml formatting fix fix: various workflows issues Aug 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 152 changed files in this pull request and generated no new comments.

Suppressed comments (1)

.github/workflows/ci.yml:61

  • This change switches PR CI from make test (which runs the bats-core suites via test/run.sh) to make itest, meaning bats-based E2E/regression coverage is no longer run automatically on pull requests. This is a significant CI behavior change (not just a formatting fix) and can make PRs look green while bats suites are failing or being skipped.

If the intent is to gate bats suites separately, consider explicitly documenting that in the PR description and ensuring the /test <suite> workflow is required (or at least prominently surfaced) for PRs that touch affected areas.

      - name: Run unit and integration tests on Ubuntu
        # BATS suites are intentionally excluded here; devs trigger them per-PR
        # via a `/test <suite>` comment (see e2e.yml + pr-comment-trigger.yml).
        env:

@sonarqubecloud

sonarqubecloud Bot commented Aug 18, 2026 •

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@avirtopeanu-ionos
avirtopeanu-ionos merged commit 7df771c into master Aug 18, 2026
10 checks passed
@avirtopeanu-ionos
avirtopeanu-ionos deleted the rm/trivy branch August 18, 2026 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants