UltraClient has reference to attribute which does not exist on Workbook class.

[tjsr]

In UltraClient.py:294 there is a call to wb.get_active_sheet(). This function does not exist and need to be cleaned up and/or corrected.

Attempting to run this test harness causes the module to crash with a stack trace.

[esitarski]

The issue is in UltraClient.py, not Ultra.py. Certainly a bug, however, this is test code and not accessible from CrossMgr. I don't know if anyone is using the Ultra system anymore. This file had multiple problems (backwards-incompatible changes to openpyxl, was using Python 2 import locations for queue), and this test has not been run for years. Anyway, fixed, and should be available in 60 minutes or so.

…

On Sun, Feb 9, 2025 at 11:05 PM Tim Rowe ***@***.***> wrote: In Ultra.py:294 there is a call to wb.get_active_sheet(). This function does not exist and need to be cleaned up and/or corrected. Attempting to run this test harness causes the module to crash with a stack trace. — Reply to this email directly, view it on GitHub <#166>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABGXKODPZJKVLAJDGXAXP32PAQPNAVCNFSM6AAAAABWZTM55WVHI2DSMVQWIX3LMV43ASLTON2WKOZSHA2DCMRXGQ3DAMY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- Edward Sitarski

[tjsr]

I don't know if anyone is using the Ultra system anymore.

We're using it with GMBC - that's the biggest reason I've started doing all this dev on CrossMgr, to make it work and be compatible.

I want to aim to use it for DirtSquirts this Sunday - I've had two weekends in a row of attempting, but then encountering issues on-site.

[tjsr]

@esitarski Just on another note - I was looking through the list of dependencies to see what observers, dispatchers or pub/sub libraries might already be used in the project so I don't just bring in a new/different one - and noticed the sheer number of different Excel libraries included in the requirements.txt file.

• xlswriter
• xlrd
• openpyxl
• xlwt

Is this worth investigating to see if the functionality and reason for requiring multiple in the past is still relevant - whether a refactor in some places can occur to just use one of these libraries and remove any?

[esitarski]

This is a "things are the way they are because they got that way".
openpyxl does not support .xls files, so xlrd is still necessary.
Over the years, different Excel libraries crept in.

I expect that openpyxl could do the job for writing files, but there is a lot of work in refactoring (not the least of which openpyxl uses 1-based indexing for rows and columns, not 0-based).
This would require a lot of testing to make sure that the Excel files are created correctly with all possible output options.
There didn't seem to be much percent return in this investment. Perhaps one day.