docs: adjust docs deploy base for custom domain

Remove the DOCS_BASE environment variable from the docs CI build step, as the custom

Author: devgauravjatt

.github/workflows/docs.yml

@@ -46,14 +46,12 @@ jobs:
       # docs/ is a separate pnpm project with its own workspace and lockfile.
       - run: pnpm install --frozen-lockfile
         working-directory: docs
-      # TEMPORARY — remove this `env:` block the moment scrollstack.js.org is
-      # attached in Settings > Pages. Until then the site is served from the bare
-      # project URL (…github.io/scrollstackjs/) and needs the matching sub-path
-      # base, or every asset 404s against the host root. See docs/.vitepress/config.ts.
+      # Builds at base '/' — scrollstack.js.org is attached, and `public/CNAME`
+      # keeps it attached across deploys. Do NOT reintroduce `DOCS_BASE` here:
+      # the sub-path base bakes /scrollstackjs/ into every asset URL, which 404s
+      # against the custom domain's root. See docs/.vitepress/config.ts.
       - run: pnpm run build
         working-directory: docs
-        env:
-          DOCS_BASE: /scrollstackjs/
 
       - uses: actions/configure-pages@v5
       - uses: actions/upload-pages-artifact@v3

docs/docs/.vitepress/config.ts

@@ -13,8 +13,9 @@ const REPO = 'https://github.com/devgauravjatt/scrollstackjs'
 //   https://scrollstack.js.org/                    → base '/'              (custom domain)
 //   https://devgauravjatt.github.io/scrollstackjs/ → base '/scrollstackjs/' (bare project URL)
 //
-// So CI passes it in. `DOCS_BASE=/scrollstackjs/` until the js.org subdomain resolves;
-// drop the env var from the workflow the moment the custom domain is attached.
+// The custom domain is attached, so CI builds at the default '/' and `public/CNAME`
+// keeps it that way. `DOCS_BASE` stays as an escape hatch for building the bare
+// project URL — setting it for a scrollstack.js.org deploy 404s every asset.
 // VitePress has no relative-base mode, so this really is either/or.
 const base = process.env.DOCS_BASE ?? '/'