Skip to content

Commit 774b85f

Browse files
committed
Address REA helper review feedback
1 parent 1947715 commit 774b85f

3 files changed

Lines changed: 18 additions & 26 deletions

File tree

‎ct/rea.sh‎

Lines changed: 8 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ var_disk="${var_disk:-80}"
1616
var_os="${var_os:-debian}"
1717
var_version="${var_version:-13}"
1818
var_arm64="${var_arm64:-no}"
19+
export var_testurl="${var_testurl:-https://github.com/community-scripts/DevScripts/issues/2696}"
1920
var_unprivileged="${var_unprivileged:-1}"
2021
var_nesting="${var_nesting:-1}"
2122
var_keyctl="${var_keyctl:-1}"
@@ -35,29 +36,17 @@ function update_script() {
3536
exit 1
3637
fi
3738

38-
RESTART_REA=0
3939
if check_for_gh_release "ghidra" "NationalSecurityAgency/ghidra"; then
40-
msg_info "Updating Ghidra"
41-
fetch_and_deploy_gh_release "ghidra" "NationalSecurityAgency/ghidra" "prebuild" "latest" "/opt/ghidra" "ghidra_*_PUBLIC_*.zip"
42-
msg_ok "Updated Ghidra"
43-
RESTART_REA=1
40+
CLEAN_INSTALL=1 fetch_and_deploy_gh_release "ghidra" "NationalSecurityAgency/ghidra" "prebuild" "latest" "/opt/ghidra" "ghidra_*_PUBLIC_*.zip"
4441
fi
4542

46-
if check_for_gh_release "rea-agents" "morluto/rea"; then
47-
msg_info "Updating REA"
48-
$STD npm install --global --allow-scripts=frida rea-agents@latest
49-
REA_PACKAGE_DIR="$(npm root -g)/rea-agents"
50-
node -p "require(process.argv[1]).version" "$REA_PACKAGE_DIR/package.json" > "$HOME/.rea-agents"
51-
msg_ok "Updated REA"
52-
RESTART_REA=1
53-
fi
43+
msg_info "Updating REA"
44+
$STD npm install --global --allow-scripts=frida rea-agents@latest
45+
msg_ok "Updated REA"
5446

55-
if [[ "$RESTART_REA" == "1" ]]; then
56-
systemctl restart rea-mcp
57-
systemctl is-active --quiet rea-mcp
58-
msg_ok "Restarted REA MCP"
59-
fi
60-
msg_ok "Update completed!"
47+
systemctl restart rea-mcp
48+
systemctl is-active --quiet rea-mcp
49+
msg_ok "Restarted REA MCP"
6150
exit
6251
}
6352

‎install/rea-install.sh‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ $STD apt install -y \
2121
binwalk \
2222
file \
2323
gdb \
24-
jq \
2524
ltrace \
2625
procps \
2726
strace \
@@ -58,8 +57,6 @@ if [[ -z "$REA_BIN" || ! -f "$REA_PACKAGE_DIR/package.json" ]]; then
5857
msg_error "REA npm package installation could not be verified"
5958
exit 1
6059
fi
61-
REA_VERSION="$(node -p "require(process.argv[1]).version" "$REA_PACKAGE_DIR/package.json")"
62-
printf '%s' "$REA_VERSION" > "$HOME/.rea-agents"
6360
msg_ok "Installed REA"
6461

6562
getent group rea >/dev/null || groupadd --system rea

‎json/rea.json‎

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,19 @@
11
{
22
"name": "REA",
33
"slug": "rea",
4-
"categories": [20],
4+
"categories": [
5+
20
6+
],
57
"date_created": "2026-11-22",
68
"type": "ct",
7-
"platforms": ["pve"],
9+
"platforms": [
10+
"pve"
11+
],
812
"updateable": true,
913
"privileged": false,
10-
"architectures": ["amd64"],
14+
"architectures": [
15+
"amd64"
16+
],
1117
"interface_port": 8765,
1218
"documentation": "https://github.com/morluto/rea#readme",
1319
"website": "https://github.com/morluto/rea",
@@ -33,7 +39,7 @@
3339
},
3440
"notes": [
3541
{
36-
"text": "The HTTP MCP endpoint has no built-in authentication. Allow TCP 8765 only from a trusted MCP gateway and expose OAuth 2.0 through a trusted HTTPS MCPHub deployment.",
42+
"text": "REA's HTTP MCP endpoint has no built-in client authentication. Restrict TCP 8765 to a trusted MCP gateway and terminate OAuth 2.0 at that gateway.",
3743
"type": "warning"
3844
},
3945
{

0 commit comments

Comments
 (0)