refactor(api): read proxy host and scheme from WHATWG URL fields

Author: EhabY

src/api/proxy.ts

@@ -53,14 +53,14 @@ export function getProxyForUrl(
 	noProxyFallback?: string | null,
 ): string {
 	const parsedUrl = URL.parse(url);
-	if (!parsedUrl?.host) {
+	if (!parsedUrl?.hostname) {
 		return ""; // Don't proxy URLs without a valid scheme or host.
 	}
 
-	const proto = parsedUrl.protocol.split(":", 1)[0];
-	// Stripping ports in this way instead of using parsedUrl.hostname to make
-	// sure that the brackets around IPv6 addresses are kept.
-	const hostname = parsedUrl.host.replace(/:\d*$/, "");
+	const proto = parsedUrl.protocol.slice(0, -1);
+	// WHATWG keeps the brackets around IPv6 hosts, so no-proxy entries like
+	// "[::1]" still match.
+	const hostname = parsedUrl.hostname;
 	const port = Number.parseInt(parsedUrl.port) || DEFAULT_PORTS[proto] || 0;
 	if (!shouldProxy(hostname, port, noProxy, noProxyFallback)) {
 		return ""; // Don't proxy URLs that match NO_PROXY.

test/unit/api/proxy.test.ts

@@ -98,6 +98,11 @@ describe("proxy", () => {
 					noProxy: "example.com:8443",
 					url: "https://example.com:8443",
 				},
+				{
+					name: "bracketed IPv6",
+					noProxy: "[::1]",
+					url: "http://[::1]:8080",
+				},
 			])(
 				"bypasses proxy when hostname matches noProxy ($name)",
 				({ noProxy, url }) => {