AWS EC2 Instance Type module

[github-actions[bot]]

A discussion dedicated to the AWS EC2 Instance Type module. Share your thoughts, questions, and feedback here.

Module Scorecard

Presentation & Onboarding	Credential Hygiene	Restricted-Environment Readiness	Engineering Quality	Overall
17 / 17	16 / 20	N/A	10 / 10	91 / 100

Drilldown

Presentation & Onboarding — 17 / 17

Criterion	Max	Score	Notes
Configuration-mode examples	12	12	README documents five distinct modes: default t3 picker, multi-family via include, custom labels via custom_metadata, architecture-aware provisioning using the instances output, and catalog-only via create_parameter = false. Each example uses sensible defaults and is self-contained.
Visual preview	5	5	README embeds ; file verified to exist at 80.6 KB.

Credential Hygiene — 16 / 20

Criterion	Max	Score	Notes
Secrets marked sensitive	16	16	The module contains no sensitive inputs (no API keys, tokens, or passwords). No sensitive = true is needed. README examples contain no inline secrets.
Non-hardcoded auth path	4	0	No README section documents an auth path (ServiceAccount, IAM, API key helper, etc.). The module itself performs no authenticated calls, but the criterion is not marked "if applicable" and no such documentation exists.

Restricted-Environment Readiness — N/A

All four criteria are excluded by construction. The module downloads nothing, installs nothing, and executes no scripts in the workspace. It reads a local instance-types.json file and creates a coder_parameter. The .scripts/update.sh is a maintainer tool for regenerating the catalog, not a workspace-executed script.

Criterion	Max	Score	Notes
Mirrorable artifact source	5	N/A	Module downloads nothing; no install URL to override.
Bring-your-own binary	10	N/A	Module installs nothing; no binary to skip.
Egress transparency	3	N/A	Module makes no external network calls at install or runtime.
Runs without sudo	2	N/A	Module executes no scripts in the workspace.

Engineering Quality — 10 / 10

Criterion	Max	Score	Notes
Input quality	6	6	All eight variables have clear description, explicit type, and sensible default. include has a validation block rejecting empty lists. custom_metadata uses a structured map(object({...})) type.
Test coverage	4	4	main.tftest.hcl contains 13 test runs covering parameter naming, order propagation, default handling, parameter disabling, family filtering (single and multi), label disambiguation, custom metadata overrides, output structure, architecture derivation (x86_64→amd64, arm64→arm64), GPU counts, and validation failure. No TypeScript component exists, so no e2e TS tests are expected.

Overall — 91 / 100

Raw 43 / 47 → round(43 / 47 × 100) = 91

Track: Utility (parameter/helper module; no agent, IDE, or app component)

---

Scored against SCORECARD.md on 2026-10-26 with solstice-1.