Repository navigation
#244 - Fix MappingTransformer: add a new property to a stdClass destination - #251
Merged
Merged
Conversation
…ty of a `\stdClass` destination (`initial_value` or `keep_input`) threw `Property '...' is not writable`, it is now added when the target is a simple property name (nested paths still throw). Update documentation, add tests. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #244.
MappingTransformercould not add a new property to a\stdClassdestination (initial_value: new \stdClass(), orkeep_inputon a\stdClassinput): the PropertyAccessor does not consider a missing\stdClassproperty as writable, and only arrays had a fallback, so it threwProperty '...' is not writable.\stdClassfallback, next to the array one, for a simple target property name (no.,[or], not empty):$result->{$targetProperty} = $transformedValue. A nested path (address.city) or an index notation ([name]) still throws, as for any other object: intermediate objects are not created;docs/reference/transformers/mapping_transformer.md(algorithm,mappingoption, note);MappingTransformerTest: new property with a\stdClassinitial_valueand withkeep_input(both fail onmain), and the non-simple paths that keep throwing.PHPUnit (805 tests), PHPStan, PHP-CS-Fixer and Rector pass, and the changed files are valid PHP 8.2.
Requirements
Breaking changes
None: this case currently throws. Nested paths and other objects behave as before.
🤖 Generated with Claude Code