Skip to content

perf(vk): cache podmetrics and stats - #105

Merged
fra98 merged 2 commits into
masterfrom
cache-vk-metrics
Sep 29, 2026
Merged

fra98 merged 2 commits into
masterfrom
cache-vk-metrics

Conversation

@fra98

@fra98 fra98 commented Sep 28, 2026

Copy link
Copy Markdown
Member

Description

Cache VK metrics

@kimchi-review

kimchi-review Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Kimchi Code Review

Property Value
Commit 8615a35
Author @fra98
Files changed 15
Review status Completed
Comments 2 (1 info, 1 warning)
Duration 169s

Summary

📊 Review Score: 72/100 (overall code quality — 0 lowest, 100 highest)
⏱️ Estimated effort to review: 3/5 (1 = trivial, 5 = very complex)

🧪 Tests: yes — Good test coverage is added: unit tests for the new cache package (cache_test.go), integration tests for the metrics proxy routes (http_test.go), and a new Ginkgo context for pod stats caching (pod_test.go). The tests exercise TTL expiration, singleflight deduplication, error caching, and the actual VK usage paths.

📝 Found 2 issue(s). See inline comments for details. (1 finding(s) referenced lines no longer in the diff and were omitted.)

What to expect

Kimchi will analyze the changes in this pull request and post:

  • A summary of the overall changes
  • Inline comments on specific lines with findings categorized by issue type

The review typically completes within a few minutes. This comment will be updated once the review is ready.

Interact with Kimchi
  • @getkimchi review — re-trigger a full review on the latest commit
  • @getkimchi summary — regenerate the PR summary
  • @getkimchi ignore — skip this PR (no review will be posted)
  • Reply to any inline comment to ask follow-up questions or request clarification
Configuration

Reviews are configured by your organization admin.
Review instructions, excluded directories, and severity thresholds can be adjusted per repository in the Kimchi dashboard.


Powered by Kimchi — AI-powered code review by CAST AI

@github-actions github-actions Bot added the perf label Sep 28, 2026
@fra98
fra98 marked this pull request as ready for review September 28, 2026 12:55

@kimchi-review kimchi-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📊 Review Score: 72/100 (overall code quality — 0 lowest, 100 highest)
⏱️ Estimated effort to review: 3/5 (1 = trivial, 5 = very complex)

🧪 Tests: yes — Good test coverage is added: unit tests for the new cache package (cache_test.go), integration tests for the metrics proxy routes (http_test.go), and a new Ginkgo context for pod stats caching (pod_test.go). The tests exercise TTL expiration, singleflight deduplication, error caching, and the actual VK usage paths.

📝 Found 2 issue(s). See inline comments for details. (1 finding(s) referenced lines no longer in the diff and were omitted.)

Comment thread cmd/virtual-kubelet/root/http.go
Comment thread pkg/utils/cache/cache.go
Comment thread cmd/virtual-kubelet/root/opts.go
Comment thread cmd/virtual-kubelet/root/http.go
Comment thread cmd/virtual-kubelet/root/opts.go Outdated
@fra98
fra98 merged commit f295489 into master Sep 29, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants