perf(vk): cache podmetrics and stats - #105
Conversation
Kimchi Code Review
Summary📊 Review Score: 72/100 (overall code quality — 0 lowest, 100 highest) 🧪 Tests: yes — Good test coverage is added: unit tests for the new 📝 Found 2 issue(s). See inline comments for details. (1 finding(s) referenced lines no longer in the diff and were omitted.) What to expectKimchi will analyze the changes in this pull request and post:
The review typically completes within a few minutes. This comment will be updated once the review is ready. Interact with Kimchi
ConfigurationReviews are configured by your organization admin. Powered by Kimchi — AI-powered code review by CAST AI |
There was a problem hiding this comment.
📊 Review Score: 72/100 (overall code quality — 0 lowest, 100 highest)
⏱️ Estimated effort to review: 3/5 (1 = trivial, 5 = very complex)
🧪 Tests: yes — Good test coverage is added: unit tests for the new cache package (cache_test.go), integration tests for the metrics proxy routes (http_test.go), and a new Ginkgo context for pod stats caching (pod_test.go). The tests exercise TTL expiration, singleflight deduplication, error caching, and the actual VK usage paths.
📝 Found 2 issue(s). See inline comments for details. (1 finding(s) referenced lines no longer in the diff and were omitted.)
Description
Cache VK metrics