diff --git a/docs/04_upgrading/upgrading_to_v4.md b/docs/04_upgrading/upgrading_to_v4.md index edb105a7..d5491add 100644 --- a/docs/04_upgrading/upgrading_to_v4.md +++ b/docs/04_upgrading/upgrading_to_v4.md @@ -31,7 +31,7 @@ await Actor.charge('my-event', count=5) ## Removal of deprecated APIs -Methods and arguments that had been deprecated in v3 are removed in v4. +Methods and arguments that had been deprecated in v3 are removed in v4, along with a few `Configuration` fields that the SDK never read. ### api_public_base_url argument of storage clients @@ -71,6 +71,12 @@ The deprecated `latest_sdk_version`, `log_format`, and `standby_port` fields hav - In place of `standby_port`, use `web_server_port`. - `latest_sdk_version` and `log_format` don't have replacement. SDK version checking isn't supported for the Python SDK and the log format should be adjusted in code instead. +### Unused `Configuration` fields + +The `disable_outdated_warning` and `fact` fields have been removed from `Configuration`. The SDK never read either of them, and `Actor.get_env()` no longer includes their keys. The corresponding `ApifyEnvVars.DISABLE_OUTDATED_WARNING` and `ApifyEnvVars.FACT` enum entries remain available. + +Neither has a replacement. SDK version checking isn't supported for the Python SDK, so there's no outdated-version warning to disable. + ### wait_for_finish argument of Actor.start The `wait_for_finish` argument of `Actor.start()` has been removed. It contradicted the purpose of `Actor.start()`, which only starts the run without waiting for it to finish. The JS SDK does not expose it on `Actor.start()` either. To wait for a run to finish, use `Actor.call()`. diff --git a/src/apify/_configuration.py b/src/apify/_configuration.py index 9731696b..cdd801c9 100644 --- a/src/apify/_configuration.py +++ b/src/apify/_configuration.py @@ -264,17 +264,6 @@ class Configuration(CrawleeConfiguration): ), ] = None - disable_outdated_warning: Annotated[ - bool, - Field( - validation_alias='apify_disable_outdated_warning', - description='Controls the display of outdated SDK version warnings', - ), - BeforeValidator(lambda val: val or False), - ] = False - - fact: Annotated[str | None, Field(validation_alias='apify_fact')] = None - input_key: Annotated[ str, Field( diff --git a/tests/unit/actor/test_actor_env_helpers.py b/tests/unit/actor/test_actor_env_helpers.py index 8b67637e..0d5adfdb 100644 --- a/tests/unit/actor/test_actor_env_helpers.py +++ b/tests/unit/actor/test_actor_env_helpers.py @@ -31,7 +31,6 @@ BOOL_ENV_VARS: list[ApifyEnvVars] = [ ApifyEnvVars.DISABLE_BROWSER_SANDBOX, - ApifyEnvVars.DISABLE_OUTDATED_WARNING, ApifyEnvVars.HEADLESS, ApifyEnvVars.IS_AT_HOME, ApifyEnvVars.PERSIST_STORAGE, @@ -62,7 +61,6 @@ ApifyEnvVars.API_BASE_URL, ApifyEnvVars.API_PUBLIC_BASE_URL, ApifyEnvVars.DEFAULT_BROWSER_PATH, - ApifyEnvVars.FACT, ApifyEnvVars.INPUT_SECRETS_PRIVATE_KEY_FILE, ApifyEnvVars.INPUT_SECRETS_PRIVATE_KEY_PASSPHRASE, ApifyEnvVars.LOCAL_STORAGE_DIR,