Skip to content

Commit 6e60c20

Browse files
ci: remove audit ignore of quick-xml advisories (#25600)
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Closes #N/A. ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. Please explain the problem you are trying to solve in terms of the user-visible behavior, rather than the implementation. For example, "The code in `foo.rs` doesn't handle nulls" is a symptom of the implementation. "COUNT(DISTINCT) returns wrong results when the column contains nulls" is the user-visible problem. --> In commit #094ad31, @alamb fixed CI failure by temporarily ignoring the two quick-xml RustSec advisories in the audit workflow and documented that the ignores should be removed once object_store upgrades to quick-xml >= 0.41.0. Now that PR #25335 has been merged, we can remove these temeporary ignores. ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here, but it is sometimes worth providing a summary of the individual changes in this PR. --> Remove the two temporary audit ignores in security_audit.sh. ## What is the testing strategy for this PR? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code Briefly describe how this PR is tested, and point to the specific tests you added. For example: 'This new feature is covered by the `sqllogictest` cases added in `foo.slt`'. If this PR does not add tests, explain why. For example, if the change is already covered by existing tests, please mention it. You should also check the `codecov` bot reply on this PR to confirm the changed code is exercised. --> Just CI update ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please add the `api change` label. --> No Signed-off-by: Jiawei Zhao <Phoenix500526@163.com>
1 parent e15d6d2 commit 6e60c20

1 file changed

Lines changed: 2 additions & 15 deletions

File tree

ci/scripts/security_audit.sh

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -31,21 +31,8 @@ if ! command -v cargo-audit &> /dev/null; then
3131
exit 1
3232
fi
3333

34-
# RUSTSEC-2026-0194 and RUSTSEC-2026-0195 are in quick-xml, reached through
35-
# object_store. Remove them once object_store upgrades to quick-xml >= 0.41.0.
36-
# https://github.com/apache/datafusion/issues/23297
37-
IGNORED_ADVISORIES=(
38-
RUSTSEC-2026-0194
39-
RUSTSEC-2026-0195
40-
)
41-
42-
IGNORE_ARGS=()
43-
for advisory in "${IGNORED_ADVISORIES[@]}"; do
44-
IGNORE_ARGS+=(--ignore "${advisory}")
45-
done
46-
4734
cd "${ROOT_DIR}"
4835

49-
echo "[${SCRIPT_NAME}] \`cargo audit ${IGNORE_ARGS[*]}\`"
36+
echo "[${SCRIPT_NAME}] \`cargo audit\`"
5037
# The guarded expansion keeps `set -u` happy on bash 3.2 (macOS) if the list is empty.
51-
cargo audit ${IGNORE_ARGS[@]+"${IGNORE_ARGS[@]}"}
38+
cargo audit

0 commit comments

Comments
 (0)