Repository navigation
Build improvements - #4728
Build improvements#4728
Conversation
82c0dc5 to
7f8a840
Compare
- Pin Rust version to 1.98.1 at Github Actions - Add rust-toolchain.toml to pin Rust version on local builds - Github Action use JDK 21 - Bump NDK version to r30 LTS - Bump Github Action versions and align arguments with reference from release/4.0 branch
7f8a840 to
7b70869
Compare
|
@IzzySoft please see if it helps |
EmmanuelMess
left a comment
There was a problem hiding this comment.
This really needs a clear way to inform the developer that the NDK version is not the one expected, especially if it needs an exact match. The error message from compilation is really not helpful, as it tells you the NDK library is missing altogether.
thanks! But with ~1k apps in our builder, I cannot remember all details for each app 🙈 So I first need to figure out "helps with what exactly… Ah, issue linked, thanks!
Guess we'll have to see if the cargo error is gone with the next release then, after this PR has been merged… |
Add check for NDK and NDK version in setup_rust_android.sh
|
|
||
| # Find NDK version | ||
| NDK_VERSION=$(find_ndk_version "$ANDROID_SDK_PATH") | ||
| # Find required NDK version from version catalog |
There was a problem hiding this comment.
Okay, this isn't shown during sync. What I see is:
A problem occurred configuring project ':file_operations'.
> NDK is not installed
* Try:
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.
* Exception is:
org.gradle.api.ProjectConfigurationException: A problem occurred configuring project ':file_operations'.
at org.gradle.configuration.project.LifecycleProjectEvaluator.wrapException(LifecycleProjectEvaluator.java:84)
at org.gradle.configuration.project.LifecycleProjectEvaluator.addConfigurationFailure(LifecycleProjectEvaluator.java:77)
at org.gradle.configuration.project.LifecycleProjectEvaluator.access$500(LifecycleProjectEvaluator.java:55)
at org.gradle.configuration.project.LifecycleProjectEvaluator$NotifyAfterEvaluate.run(LifecycleProjectEvaluator.java:255)
at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:30)
at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:27)
at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:67)
at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:60)
There was a problem hiding this comment.
This is important because it is what people will see when first setting up the project.
EmmanuelMess
left a comment
There was a problem hiding this comment.
Rubber stamping to make a release.
|
If you give me a ping once there's a build we can check against, I can see to it 🤗 |
Description
Please install NDK 30 (
30.0.16248370) before running the build locally.Changes:
rust-toolchain.tomlto pin Rust version on local buildslibs.versions.tomlrelease/4.0branch for latest versions of Github Actions and syntaxesIssue tracker
Fixes #4551 (hopefully)
Automatic tests
N/A
Manual tests
Done
Device:
OS:
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheckGenerative code
AI was used in pointing out the use of Rust toolchain overrides
rust-toolchain.tomlduring research.